This is an archive of the discontinued LLVM Phabricator instance.

Make le64 DescriptionString consistent with other targets.
ClosedPublic

Authored by jfb on Dec 2 2014, 11:01 AM.

Reviewers

dschuff
sdt

Commits

Summary

In particular, remove the defaults and reorder fields so it matches the result of DataLayout::getStringDescription().

Change by David Neto.

jfb retitled this revision from to Make le64 DescriptionString consistent with other targets..

jfb updated this object.

jfb edited the test plan for this revision. (Show Details)

jfb added reviewers: dschuff, sdt.

jfb added a subscriber: Unknown Object (MLST).

sdt accepted this revision.Dec 2 2014, 11:03 AM

sdt edited edge metadata.

This revision is now accepted and ready to land.Dec 2 2014, 11:03 AM

Closed by commit rL223140 (authored by @jfb).

Path

Size

cfe/

trunk/

lib/

Basic/

2 lines

	Show First 20 Lines • Show All 6,055 Lines • ▼ Show 20 Lines

	public:			public:
	Le64TargetInfo(const llvm::Triple &Triple) : TargetInfo(Triple) {			Le64TargetInfo(const llvm::Triple &Triple) : TargetInfo(Triple) {
	BigEndian = false;			BigEndian = false;
	NoAsmVariants = true;			NoAsmVariants = true;
	LongWidth = LongAlign = PointerWidth = PointerAlign = 64;			LongWidth = LongAlign = PointerWidth = PointerAlign = 64;
	MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64;			MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64;
	DescriptionString =			DescriptionString =
	"e-S128-p:64:64-v16:16-v32:32-v64:64-v96:32-v128:32-m:e-n8:16:32:64";			"e-m:e-v128:32-v16:16-v32:32-v96:32-n8:16:32:64-S128";
	}			}

	void getTargetDefines(const LangOptions &Opts,			void getTargetDefines(const LangOptions &Opts,
	MacroBuilder &Builder) const override {			MacroBuilder &Builder) const override {
	DefineStd(Builder, "unix", Opts);			DefineStd(Builder, "unix", Opts);
	defineCPUMacros(Builder, "le64", /Tuning=/false);			defineCPUMacros(Builder, "le64", /Tuning=/false);
	Builder.defineMacro("__ELF__");			Builder.defineMacro("__ELF__");
	}			}
	▲ Show 20 Lines • Show All 615 Lines • Show Last 20 Lines