This is an archive of the discontinued LLVM Phabricator instance.

libc++: support NaCl when building thread.cpp
ClosedPublic

Authored by jfb on Dec 1 2014, 5:24 PM.

Details

Summary

NaCl shouldn't include sysctl.h when trying to determine std::thread::hardware_concurrency, it should instead use sysconf(_SC_NPROCESSORS_ONLN) through unistd.h. No test needs to be changed, since hardware_concurrency.pass.cpp already tests that std::thread::hardware_concurrency > 0.

Diff Detail

Repository
rL LLVM

Event Timeline

jfb updated this revision to Diff 16793.Dec 1 2014, 5:24 PM
jfb retitled this revision from to libc++: support NaCl when building thread.cpp.
jfb updated this object.
jfb edited the test plan for this revision. (Show Details)
jfb added reviewers: dschuff, danalbert.
jfb added a subscriber: Unknown Object (MLST).
dschuff accepted this revision.Dec 2 2014, 9:30 AM
dschuff edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 2 2014, 9:30 AM
jfb closed this revision.Dec 2 2014, 9:30 AM
jfb updated this revision to Diff 16817.

Closed by commit rL223128 (authored by @jfb).