This is an archive of the discontinued LLVM Phabricator instance.

[Msan] Fix some interceptors to pass initialization on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Nov 26 2014, 5:04 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 retitled this revision from to [Msan] Fix some interceptors to pass initialization on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added a subscriber: Unknown Object (MLST).
eugenis accepted this revision.Nov 27 2014, 1:56 AM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 27 2014, 1:56 AM

In fact, I've seen getenv() on linux not working properly during MSan initialization, because it happens in .preinit_array and environ is simply not set at this point.

Just FYI. If msan_init somehow caused getenv() call, it might be getting unexpected results.

In fact, I've seen getenv() on linux not working properly during MSan initialization, because it happens in .preinit_array and environ is simply not set at this point.
Just FYI. If msan_init somehow caused getenv() call, it might be getting unexpected results.

Just checked it and it looks getenv() is fully workable at the moment of its first call. Thanks.

Diffusion closed this revision.Nov 27 2014, 6:29 AM
Diffusion updated this revision to Diff 16692.

Closed by commit rL222885 (authored by vkutuzov).