This is an archive of the discontinued LLVM Phabricator instance.

[Msan] Check returning value of DTLS_Get()
ClosedPublic

Authored by kutuzov.viktor.84 on Nov 25 2014, 3:01 AM.

Reviewers

kcc
samsonov

Commits

Summary

DTLS_Get() returns 0 if SANITIZER_INTERCEPT_TLS_GET_ADDR expands to zero value.

kutuzov.viktor.84 retitled this revision from to [Msan] Check returning value of DTLS_Get().

kutuzov.viktor.84 updated this object.

kutuzov.viktor.84 edited the test plan for this revision. (Show Details)

kutuzov.viktor.84 added a subscriber: Unknown Object (MLST).

LGTM

This revision is now accepted and ready to land.Nov 25 2014, 10:11 AM

Closed by commit rL222818 (authored by vkutuzov).

Path

Size

compiler-rt/

trunk/

lib/

msan/

1 line

Show All 30 Lines	void MsanThread::SetThreadStackAndTls() {
CHECK(AddrIsInStack((uptr)&local));		CHECK(AddrIsInStack((uptr)&local));
}		}

void MsanThread::ClearShadowForThreadStackAndTLS() {		void MsanThread::ClearShadowForThreadStackAndTLS() {
__msan_unpoison((void *)stack_bottom_, stack_top_ - stack_bottom_);		__msan_unpoison((void *)stack_bottom_, stack_top_ - stack_bottom_);
if (tls_begin_ != tls_end_)		if (tls_begin_ != tls_end_)
__msan_unpoison((void *)tls_begin_, tls_end_ - tls_begin_);		__msan_unpoison((void *)tls_begin_, tls_end_ - tls_begin_);
DTLS *dtls = DTLS_Get();		DTLS *dtls = DTLS_Get();
		CHECK_NE(dtls, 0);
for (uptr i = 0; i < dtls->dtv_size; ++i)		for (uptr i = 0; i < dtls->dtv_size; ++i)
__msan_unpoison((void *)(dtls->dtv[i].beg), dtls->dtv[i].size);		__msan_unpoison((void *)(dtls->dtv[i].beg), dtls->dtv[i].size);
}		}

void MsanThread::Init() {		void MsanThread::Init() {
SetThreadStackAndTls();		SetThreadStackAndTls();
CHECK(MEM_IS_APP(stack_bottom_));		CHECK(MEM_IS_APP(stack_bottom_));
CHECK(MEM_IS_APP(stack_top_ - 1));		CHECK(MEM_IS_APP(stack_top_ - 1));
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines