This is an archive of the discontinued LLVM Phabricator instance.

Drop Cloog support
ClosedPublic

Authored by jdoerfert on Nov 24 2014, 7:32 PM.

Details

Summary
This commit drops the Cloog support for Polly. The scripts and
documentation are changed to only use isl as prerequisity. In the code
all Cloog specific parts have been removed.

TODO: This commit removes all Cloog tests, however, we should port
      them to the isl backend.

Diff Detail

Event Timeline

jdoerfert updated this revision to Diff 16596.Nov 24 2014, 7:32 PM
jdoerfert retitled this revision from to Drop Cloog support.
jdoerfert updated this object.
jdoerfert edited the test plan for this revision. (Show Details)
jdoerfert added subscribers: Restricted Project, Unknown Object (MLST).
grosser accepted this revision.Nov 24 2014, 11:23 PM
grosser edited edge metadata.

Great,

this removes a lot of old code. Thanks Johannes for going through all the documentation and website.

Regarding the old CLooG tests. When we have written the isl backend we went through them already once and ported the tests we considered important. The same was true when the OpenMP backend was added. So many important tests are already ported. Just moving all of them to isl will just give us many redundant tests. We could possibly go through them 1-by-1, but I don't have the feeling we would loose too much test coverage if we just drop them.

LGTM, if tested (and the scoplib changes are removed)

configure
598

scoplib sneaked back in for whatever reason.

661

Why is scoplib back?

1293

Why is scoplib back?

2586

Why scoplib again?

www/documentation/gpgpucodegen.html
125

The old GPGPU codegen onlyworked with the CLooG backend. No need to update it. We can drop it as well (possibly in a later commit).

This revision is now accepted and ready to land.Nov 24 2014, 11:23 PM

Any plans to commit this patch?

I would like to push an isl update and recent isl versions break a CLooG regression test. So I would prefer to only commit them after we removed CLooG to not causing failing tests for someone.

jdoerfert updated this revision to Diff 16813.Dec 2 2014, 8:55 AM
jdoerfert edited edge metadata.

Removed scoplib from the configure file

Also, please add a symbolic link from checkout_cloog.sh to checkout_isl.sh.

This is hopefully enough to make the buildbots happy. After we updated zorg, we can drop this.

Otherwise we can commit this patch now. If there are fallouts, we can fix them as they appear.

Cheers,
Tobias

utils/checkout_isl.sh
69

We need a cd ${ISL_DIR}/.. here. Otherwise, git complains of not being inside a valid working directory.

jdoerfert closed this revision.Dec 2 2014, 11:28 AM

Commited in r223141.

test/Cloog/ScopDetection/single_function_only.ll