This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Make the MSAN wmemset intercepter call wmemset instead of memset. Fixes PR 21579
ClosedPublic

Authored by EricWF on Nov 20 2014, 5:44 PM.

Details

Summary

Exactly what the title says. I've tested this change against the libc++ test failures and it solves all of them. The check-msan rule also still passes.
I'm not sure why it called memset originally.

I can add tests if requested but currently there are no tests involving wide chars and they are a c++11 features.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 16466.Nov 20 2014, 5:44 PM
EricWF retitled this revision from to [compiler-rt] Make the MSAN wmemset intercepter call wmemset instead of memset. Fixes PR 21579.
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added reviewers: kcc, eugenis.
EricWF added a subscriber: Unknown Object (MLST).
eugenis accepted this revision.Nov 21 2014, 1:49 AM
eugenis edited edge metadata.

Ouch.
Thanks a lot.
There are some wchar_t tests in lib/msan/tests/msan_test.cc, please add one.

This revision is now accepted and ready to land.Nov 21 2014, 1:49 AM
EricWF updated this revision to Diff 16516.Nov 21 2014, 3:58 PM
EricWF edited edge metadata.

Added a test case. Could somebody just double check it looks sane? I'm not quite comfortable with the msan test suite.

EricWF updated this revision to Diff 16517.Nov 21 2014, 3:59 PM

Woops, The last test case was wrong. Correct test case attached. Sorry for the noise.

Looks great.

EricWF closed this revision.Nov 24 2014, 10:17 AM