This is an archive of the discontinued LLVM Phabricator instance.

Add support for LLVM_USE_SANITIZER=Thread
ClosedPublic

Authored by EricWF on Nov 14 2014, 5:45 PM.

Details

Summary

This will help in testing libc++ and libc++abi with tsan.

Diff Detail

Repository
rL LLVM

Event Timeline

EricWF updated this revision to Diff 16256.Nov 14 2014, 5:45 PM
EricWF retitled this revision from to Add support for LLVM_USE_SANITIZER=Thread.
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added a subscriber: Unknown Object (MLST).
samsonov accepted this revision.Nov 16 2014, 12:01 PM
samsonov added a reviewer: samsonov.
samsonov added a subscriber: samsonov.

Looks reasonable. Have you tested LLVM test suite with this option enabled? Does it pass?

This revision is now accepted and ready to land.Nov 16 2014, 12:01 PM

Thanks for the review. I just did a run and saw about 4 failures in the LLVM test suite. The build was clean though.

EricWF closed this revision.Nov 18 2014, 1:23 PM
EricWF closed this revision.Nov 18 2014, 1:23 PM
EricWF updated this revision to Diff 16349.

Closed by commit rL222258 (authored by @EricWF).