This is an archive of the discontinued LLVM Phabricator instance.

Ensure definition of uppercase_CMAKE_BUILD_TYPE is available in HandleLLVMOptions.cmake module.
AbandonedPublic

Authored by EricWF on Nov 14 2014, 4:21 PM.

Details

Reviewers
None
Summary

HandleLLVMOptionsis used by libc++abi without including llvm/CMakeLists.txt when doing standalone builds. This means that uppercase_CMAKE_BUILD_TYPE is undefined. However uppercase_CMAKE_BUILD_TYPE is used in HandleLLVMOptions. This patch ensures that it is defined.

This might be a silly patch to ask for review on but I don't commit to LLVM often.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 16254.Nov 14 2014, 4:21 PM
EricWF retitled this revision from to Ensure definition of uppercase_CMAKE_BUILD_TYPE is available in HandleLLVMOptions.cmake module..
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added a subscriber: Unknown Object (MLST).
EricWF abandoned this revision.Nov 14 2014, 11:46 PM

This seems like a good candidate for post commit review.