This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Fix vector annotator size increase in `vector::insert(pos, count, value)`
ClosedPublic

Authored by EricWF on Nov 13 2014, 11:00 PM.

Details

Summary

The size of the vector is being increased by __n during the call to __move_range and not by 1.
This fixes a test failure in containers/sequences/vector/vector.modifiers/insert_iter_size_value.pass.cpp when using ASAN.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 16199.Nov 13 2014, 11:00 PM
EricWF retitled this revision from to [libcxx] Fix vector annotator size increase in `vector::insert(pos, count, value)`.
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added reviewers: mclow.lists, danalbert, kcc.
EricWF added a subscriber: Unknown Object (MLST).
kcc edited edge metadata.Nov 14 2014, 8:42 AM

can you re-send the patch with more context?

EricWF updated this revision to Diff 16221.Nov 14 2014, 9:29 AM
EricWF edited edge metadata.

This should have more context unless phab does something funny.

mclow.lists accepted this revision.Nov 14 2014, 10:12 AM
mclow.lists edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 14 2014, 10:12 AM
EricWF closed this revision.Nov 14 2014, 10:28 AM