This is an archive of the discontinued LLVM Phabricator instance.

[ASan] Fix stack-overflow test for PowerPC
ClosedPublic

Authored by foad on Nov 7 2014, 9:05 AM.

Details

Summary

Tweak the asan stack overflow heuristics to cope with PowerPC64 redzones,
which are larger than on x86-64: 288 bytes for big-endian and 512 bytes
for little-endian.

Diff Detail

Event Timeline

foad updated this revision to Diff 15925.Nov 7 2014, 9:05 AM
foad retitled this revision from to [ASan] Fix stack-overflow test for PowerPC.
foad updated this object.
foad edited the test plan for this revision. (Show Details)
foad added reviewers: kcc, samsonov, willschm, eugenis.
foad added a subscriber: Unknown Object (MLST).
foad updated this object.Nov 7 2014, 10:05 AM
foad updated this object.
samsonov accepted this revision.Nov 7 2014, 11:44 AM
samsonov edited edge metadata.

Looks reasonable to me. Evgeniy, any objections?

This revision is now accepted and ready to land.Nov 7 2014, 11:44 AM
eugenis accepted this revision.Nov 8 2014, 1:31 AM
eugenis edited edge metadata.

Perfect.
Writing tests finally pays off :)

foad closed this revision.Nov 8 2014, 2:02 AM