Enable standard so versioning for libLLVM.

[beanz]

Summary

This resolves Bugzilla bug 15493.

[chapuni]

Looks good. Although I could accept this, excuse me to sit here to listen in more opinions.

I wish this logic into llvm_add_library(). Versioning may be general among shared libs. I will do in future.

FYI, autoconf's --enable-shared emits the library like libLLVM-3.6.0svn.so.

In llvm-shlib/Makefile;

LIBRARYNAME = LLVM-$(LLVM_VERSION_MAJOR).$(LLVM_VERSION_MINOR)$(LLVM_VERSION_SUFFIX)
LIBRARYALIASNAME = LLVM-$(LLVMVersion)

In Makefile.config;

LLVMVersion       := 3.6.0svn
LLVM_VERSION_MAJOR := 3
LLVM_VERSION_MINOR := 6
LLVM_VERSION_PATCH := 0
LLVM_VERSION_SUFFIX := svn

To which way shall we follow?

[beanz]

I think you are right, and that is a better way to handle this problem. I'll work on updated patches. I'll also add the LLVM_VERSION_SUFFIX to match the autotools implementation so that we have parity.

[beanz]

Moved the so versioning support into llvm_add_library so that it applies to all shared libraries, not just libLLVM.

[beanz]

Ping?

[pete]

Updated patch LGTM.

llvm/trunk/CMakeLists.txt

set(CMAKE_MODULE_PATH
   ${CMAKE_MODULE_PATH}
   "${CMAKE_CURRENT_SOURCE_DIR}/cmake"
   "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"
   )
 
 set(LLVM_VERSION_MAJOR 3)
 set(LLVM_VERSION_MINOR 7)
 set(LLVM_VERSION_PATCH 0)
+set(LLVM_VERSION_SUFFIX svn)
 
 if (NOT PACKAGE_VERSION)
   set(PACKAGE_VERSION "${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}svn")
 endif()
 
 option(LLVM_INSTALL_TOOLCHAIN_ONLY "Only include toolchain files in the 'install' target." OFF)
 
 option(LLVM_USE_FOLDERS "Enable solution folders in Visual Studio. Disable for Express versions." ON)

llvm/trunk/cmake/modules/AddLLVM.cmake

function(llvm_add_library name)
   endif()
 
   if(ARG_SHARED)
     if(WIN32)
       set_target_properties(${name} PROPERTIES
         PREFIX ""
         )
     endif()
+    
+    set_target_properties(${name}
+      PROPERTIES
+      SOVERSION ${LLVM_VERSION_MAJOR}
+      VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX})
   endif()
 
   if(ARG_MODULE OR ARG_SHARED)
     # Do not add -Dname_EXPORTS to the command-line when building files in this
     # target. Doing so is actively harmful for the modules build because it
     # creates extra module variants, and not useful because we don't use these
     # macros.
     set_target_properties( ${name} PROPERTIES DEFINE_SYMBOL "" )