This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Introduce MACOS_VERSION_UNKNOWN_NEWER for OS X versions above 10.10
ClosedPublic

Authored by kubamracek on Nov 5 2014, 11:49 AM.

Details

Reviewers
glider
samsonov
Summary

We recently had a broken version check because an newer OS X version is treated as MACOS_VERSION_UNKNOWN which is less than all the defined values. Let's have a separate enum value for unknown but newer versions, so the ">=" and "<=" version checks still work even in upcoming OS X releases.

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 15822.Nov 5 2014, 11:49 AM
kubamracek retitled this revision from to [compiler-rt] Introduce MACOS_VERSION_UNKNOWN_NEWER for OS X versions above 10.10.
kubamracek updated this object.
kubamracek edited the test plan for this revision. (Show Details)
kubamracek added a subscriber: Unknown Object (MLST).
samsonov accepted this revision.Dec 15 2014, 5:43 PM
samsonov added a reviewer: samsonov.

LGTM

This revision is now accepted and ready to land.Dec 15 2014, 5:43 PM
kubamracek closed this revision.Dec 15 2014, 8:47 PM

Landed in r224315 with a modification to use IsDigit() instead of the multiple case labels.