This is an archive of the discontinued LLVM Phabricator instance.

Differential D6120

[compiler-rt] Extend the OS X pthread_get_stacksize_np workaround to 10.10
ClosedPublic

Authored by kubamracek on Nov 4 2014, 11:14 AM.

Details

Reviewers
glider
Summary

Fixes a failing ASan testcase (TestCases/stack-use-after-return.cc) on OS X 10.10. Depends on http://reviews.llvm.org/D6119.

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 15774.Nov 4 2014, 11:14 AM
kubamracek retitled this revision from to [compiler-rt] Extend the OS X pthread_get_stacksize_np workaround to 10.10.
kubamracek updated this object.
kubamracek edited the test plan for this revision. (Show Details)
kubamracek added a subscriber: Unknown Object (MLST).
glider accepted this revision.Nov 5 2014, 7:15 AM
glider added a reviewer: glider.
glider added a subscriber: glider.

LGTM :(

This revision is now accepted and ready to land.Nov 5 2014, 7:15 AM
kubamracek closed this revision.Nov 5 2014, 11:06 AM

Landed in r221380.

Revision Contents

PathSize
projects/
compiler-rt/
lib/
sanitizer_common/
2 lines

Diff 15774

projects/compiler-rt/lib/sanitizer_common/sanitizer_mac.cc

Context not available.
// pthread_get_stacksize_np() returns an incorrect stack size for the main // pthread_get_stacksize_np() returns an incorrect stack size for the main
// thread on Mavericks. See // thread on Mavericks. See
// https://code.google.com/p/address-sanitizer/issues/detail?id=261 // https://code.google.com/p/address-sanitizer/issues/detail?id=261
if ((GetMacosVersion() == MACOS_VERSION_MAVERICKS) && at_initialization && if ((GetMacosVersion() >= MACOS_VERSION_MAVERICKS) && at_initialization &&
stacksize == (1 << 19)) { stacksize == (1 << 19)) {
struct rlimit rl; struct rlimit rl;
CHECK_EQ(getrlimit(RLIMIT_STACK, &rl), 0); CHECK_EQ(getrlimit(RLIMIT_STACK, &rl), 0);
Context not available.