This is an archive of the discontinued LLVM Phabricator instance.

Change logic in StackMaps::recordStackMapOpers to use the isInt<32> predicate instead of bitwise operations.
ClosedPublic

Authored by sanjoy on Nov 3 2014, 2:31 PM.

Reviewers

ributzka

Summary

(Non functional change)

sanjoy retitled this revision from to Change logic in StackMaps::recordStackMapOpers to use the isInt<32> predicate instead of bitwise operations..

sanjoy updated this object.

sanjoy edited the test plan for this revision. (Show Details)

sanjoy added a reviewer: ributzka.

sanjoy added a subscriber: Unknown Object (MLST).

LGTM

This revision is now accepted and ready to land.Nov 3 2014, 2:56 PM

Path

Size

lib/

CodeGen/

3 lines

Show First 20 Lines • Show All 214 Lines • ▼ Show 20 Lines	while (MOI != MOE) {
MOI = parseOperand(MOI, MOE, Locations, LiveOuts);		MOI = parseOperand(MOI, MOE, Locations, LiveOuts);
}		}

// Move large constants into the constant pool.		// Move large constants into the constant pool.
for (LocationVec::iterator I = Locations.begin(), E = Locations.end();		for (LocationVec::iterator I = Locations.begin(), E = Locations.end();
I != E; ++I) {		I != E; ++I) {
// Constants are encoded as sign-extended integers.		// Constants are encoded as sign-extended integers.
// -1 is directly encoded as .long 0xFFFFFFFF with no constant pool.		// -1 is directly encoded as .long 0xFFFFFFFF with no constant pool.
if (I->LocType == Location::Constant &&		if (I->LocType == Location::Constant && !isInt<32>(I->Offset)) {
((I->Offset + (int64_t(1)<<31)) >> 32) != 0) {
I->LocType = Location::ConstantIndex;		I->LocType = Location::ConstantIndex;
auto Result = ConstPool.insert(std::make_pair(I->Offset, I->Offset));		auto Result = ConstPool.insert(std::make_pair(I->Offset, I->Offset));
I->Offset = Result.first - ConstPool.begin();		I->Offset = Result.first - ConstPool.begin();
}		}
}		}

// Create an expression to calculate the offset of the callsite from function		// Create an expression to calculate the offset of the callsite from function
// entry.		// entry.
▲ Show 20 Lines • Show All 284 Lines • Show Last 20 Lines