This is an archive of the discontinued LLVM Phabricator instance.

Differential D5983

test/lldbtest.py exception handling fix
Needs ReviewPublic

Authored by ovyalov on Oct 24 2014, 12:04 PM.

Download Raw Diff

Details

Reviewers

clayborg

Summary

Hello,

I was running tests on my Ubuntu and noticed that sometimes lldb and inferior process remained in process list after test run is completed:

ps -elf | grep lldb

0 S ovyalov 13653 4457 0 80 0 - 125362 futex_ 11:09 ? 00:00:00 /usr/local/home/ovyalov/projects/lldb/git/build/bin/lldb --no-lldbinit -b -o break set -n main -o run -o continue /usr/local/home/ovyalov/projects/lldb/git/lldb/test/driver/batch_mode/a.out -- CRASH
0 t ovyalov 13783 13653 0 80 0 - 1049 ptrace 11:09 pts/60 00:00:00 /usr/local/home/ovyalov/projects/lldb/git/lldb/test/driver/batch_mode/a.out CRASH
0 S ovyalov 14124 4457 0 80 0 - 125362 futex_ 11:43 ? 00:00:00 /usr/local/home/ovyalov/projects/lldb/git/build/bin/lldb --no-lldbinit -b -o break set -n main -o run -o continue /usr/local/home/ovyalov/projects/lldb/git/lldb/test/driver/batch_mode/a.out -- CRASH
0 t ovyalov 14299 14124 0 80 0 - 1049 ptrace 11:43 pts/67 00:00:00 /usr/local/home/ovyalov/projects/lldb/git/lldb/test/driver/batch_mode/a.out CRASH
0 S ovyalov 14803 14689 0 80 0 - 125297 futex_ 17:15 pts/55 00:00:00 ./lldb --no-lldbinit -b -o break set -n main -o run -o continue /usr/local/home/ovyalov/projects/lldb/git/lldb/test/driver/batch_mode/a.out -- NOCRASH
0 t ovyalov 14809 14803 0 80 0 - 1048 ptrace 17:15 pts/58 00:00:00 /usr/local/home/ovyalov/projects/lldb/git/lldb/test/driver/batch_mode/a.out NOCRASH
0 S ovyalov 14837 28698 0 80 0 - 5936 pipe_w 17:16 pts/57 00:00:00 grep --color=auto lldb

As I found out, the problem is in lldbtest.py which improperly handles exceptions. I've attached a patch to address this issue - please let me know whether it looks okay.

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 15433.Oct 24 2014, 12:04 PM

ovyalov retitled this revision from to test/lldbtest.py exception handling fix.

ovyalov updated this object.

ovyalov edited the test plan for this revision. (Show Details)

ovyalov added a reviewer: clayborg.

ovyalov added a subscriber: Unknown Object (MLST).

Submitted by jingham as r220583 - sorry for duplicated review request.

Revision Contents

Path

Size

test/

lldbtest.py

8 lines

Diff 15433

test/lldbtest.py

Context not available.
	self.child.sendline('settings set interpreter.prompt-on-quit false')	self.child.sendline('settings set interpreter.prompt-on-quit false')
	self.child.sendline('quit')	self.child.sendline('quit')
	self.child.expect(pexpect.EOF)	self.child.expect(pexpect.EOF)
	except ValueError, ExceptionPexpect:	except (ValueError, pexpect.ExceptionPexpect):
	# child is already terminated	# child is already terminated
	pass	pass
		finally:
	# Give it one final blow to make sure the child is terminated.	# Give it one final blow to make sure the child is terminated.
	self.child.close()	self.child.close()


	def tearDown(self):	def tearDown(self):
Context not available.