This is an archive of the discontinued LLVM Phabricator instance.

Differential D5953

Always transmit SIGPROF back to the inferior.
ClosedPublic

Authored by sas on Oct 23 2014, 6:55 PM.

Details

Reviewers
clayborg
tfiala
Commits
rG15d810fa29b3: Always transmit SIGPROF back to the inferior.
rLLDB221011: Always transmit SIGPROF back to the inferior.
rL221011: Always transmit SIGPROF back to the inferior.
Summary

SIGPROF is used for profiling processes (with google-perftools for
instance), which results in the inferior receiving a SIGPROF from the
kernel every few milliseconds. Instead of stopping the debugging session
and notifying the user of this, we should just pass the signal and keep
running.

This follows the behavior we have in UnixSignals.cpp.

Diff Detail

Repository
rL LLVM

Event Timeline

sas updated this revision to Diff 15372.Oct 23 2014, 6:55 PM
sas retitled this revision from to Always transmit SIGPROF back to the inferior..
sas updated this object.
sas edited the test plan for this revision. (Show Details)
sas added a subscriber: Unknown Object (MLST).
sas added reviewers: tfiala, clayborg.Oct 23 2014, 7:00 PM
sas added a comment.Oct 27 2014, 2:25 PM

Ping.

clayborg accepted this revision.Oct 27 2014, 2:35 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Oct 27 2014, 2:35 PM
sas closed this revision.Oct 31 2014, 3:48 PM
sas updated this revision to Diff 15657.

Closed by commit rL221011 (authored by @sas).

Revision Contents

PathSize
lldb/
trunk/
source/
Plugins/
Process/
Utility/
2 lines

Diff 15657

lldb/trunk/source/Plugins/Process/Utility/LinuxSignals.cpp

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 LinesLinuxSignals::Reset()
AddSignal (19, "SIGSTOP", "STOP", true , true , true , "process stop"); AddSignal (19, "SIGSTOP", "STOP", true , true , true , "process stop");
AddSignal (20, "SIGTSTP", "TSTP", false, true , true , "tty stop"); AddSignal (20, "SIGTSTP", "TSTP", false, true , true , "tty stop");
AddSignal (21, "SIGTTIN", "TTIN", false, true , true , "background tty read"); AddSignal (21, "SIGTTIN", "TTIN", false, true , true , "background tty read");
AddSignal (22, "SIGTTOU", "TTOU", false, true , true , "background tty write"); AddSignal (22, "SIGTTOU", "TTOU", false, true , true , "background tty write");
AddSignal (23, "SIGURG", "URG", false, true , true , "urgent data on socket"); AddSignal (23, "SIGURG", "URG", false, true , true , "urgent data on socket");
AddSignal (24, "SIGXCPU", "XCPU", false, true , true , "CPU resource exceeded"); AddSignal (24, "SIGXCPU", "XCPU", false, true , true , "CPU resource exceeded");
AddSignal (25, "SIGXFSZ", "XFSZ", false, true , true , "file size limit exceeded"); AddSignal (25, "SIGXFSZ", "XFSZ", false, true , true , "file size limit exceeded");
AddSignal (26, "SIGVTALRM", "VTALRM", false, true , true , "virtual time alarm"); AddSignal (26, "SIGVTALRM", "VTALRM", false, true , true , "virtual time alarm");
AddSignal (27, "SIGPROF", "PROF", false, true , true , "profiling time alarm"); AddSignal (27, "SIGPROF", "PROF", false, false, false, "profiling time alarm");
AddSignal (28, "SIGWINCH", "WINCH", false, true , true , "window size changes"); AddSignal (28, "SIGWINCH", "WINCH", false, true , true , "window size changes");
AddSignal (29, "SIGPOLL", "POLL", false, true , true , "pollable event"); AddSignal (29, "SIGPOLL", "POLL", false, true , true , "pollable event");
AddSignal (29, "SIGIO", "IO", false, true , true , "input/output ready"); AddSignal (29, "SIGIO", "IO", false, true , true , "input/output ready");
AddSignal (30, "SIGPWR", "PWR", false, true , true , "power failure"); AddSignal (30, "SIGPWR", "PWR", false, true , true , "power failure");
AddSignal (31, "SIGSYS", "SYS", false, true , true , "invalid system call"); AddSignal (31, "SIGSYS", "SYS", false, true , true , "invalid system call");
} }