This is an archive of the discontinued LLVM Phabricator instance.

Fix LexicalScope reset in LiveDebugVariables.cpp
ClosedPublic

Authored by kariddi on Oct 23 2014, 5:52 PM.

Details

Reviewers
dblaikie
Summary

Hello,

I noticed by inspection that in LiveDebugVariables.cpp we don't actually reset the LexicalScope when we clear() the LDVImpl object.
This might create problems if we rely on clearing the object.
This patch fixes that.

Diff Detail

Event Timeline

kariddi updated this revision to Diff 15361.Oct 23 2014, 5:52 PM
kariddi retitled this revision from to Fix LexicalScope reset in LiveDebugVariables.cpp.
kariddi updated this object.
kariddi edited the test plan for this revision. (Show Details)
kariddi set the repository for this revision to rL LLVM.
kariddi added a subscriber: Unknown Object (MLST).
dblaikie accepted this revision.Oct 23 2014, 7:06 PM
dblaikie added a reviewer: dblaikie.
dblaikie added a subscriber: dblaikie.

It's harmless enough - I think the only particular benefit is in 'releaseMemory', causing this to release the memory of the LexicalScopes too.

This revision is now accepted and ready to land.Oct 23 2014, 7:06 PM

Thanks, committed in r220545

kariddi closed this revision.Oct 23 2014, 9:00 PM