This is an archive of the discontinued LLVM Phabricator instance.

Separated RecursiveASTVisitorTest into multiple files to prevent the necessity of using /bigobj on MSVC.
ClosedPublic

Authored by curdeius on Oct 8 2014, 6:11 AM.

Details

Diff Detail

Event Timeline

curdeius updated this revision to Diff 14569.Oct 8 2014, 6:11 AM
curdeius retitled this revision from to Separated RecursiveASTVisitorTest into multiple files to prevent the necessity of using /bigobj on MSVC..
curdeius updated this object.
curdeius edited the test plan for this revision. (Show Details)
curdeius added a subscriber: curdeius.
curdeius added a subscriber: Unknown Object (MLST).
klimek accepted this revision.Oct 8 2014, 7:30 AM
klimek edited edge metadata.

I like the splitting up, even though I think it's for the wrong reasons :)

This revision is now accepted and ready to land.Oct 8 2014, 7:30 AM

Well, another reason was to keep it easy to digest in smaller chunks, but yes I didn't mention it even if it is more important.
Can you please land it as I have no write access.
The error on MSVC was annoying though.

unittests/Tooling/TestVisitor.h
234

Wrong header guard comment removed.

curdeius closed this revision.Oct 10 2014, 1:33 AM

Commited by klimek in r219410.