This is an archive of the discontinued LLVM Phabricator instance.

Differential D5651

COFF generator correction: SECTION relocation size changed to 16 bit from 32
ClosedPublic

Authored by aguskov on Oct 7 2014, 9:14 AM.

Details

Reviewers
timurrrr

Diff Detail

Event Timeline

aguskov updated this revision to Diff 14515.Oct 7 2014, 9:14 AM
aguskov retitled this revision from to COFF generator correction: SECTION relocation size changed to 16 bit from 32.
aguskov updated this object.
aguskov edited the test plan for this revision. (Show Details)
aguskov added a reviewer: timurrrr.
aguskov changed the visibility from "Public (No Login Required)" to "All Users".
aguskov added a subscriber: Unknown Object (MLST).
timurrrr edited edge metadata.Oct 7 2014, 9:18 AM

Minor nits follow:

lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp
169

nit: after a 16-bit section index

lib/MC/WinCOFFStreamer.cpp
165

Wording: please use just

// Unlike 32-bit SECREL, section index is just 16-bit.
test/MC/COFF/secidx.s
7

I suggest we add .short 0 between these as we've yet to see a .secidx directive which is not 4-byte aligned (right?).

timurrrr edited edge metadata.Oct 8 2014, 10:59 AM
timurrrr changed the visibility from "All Users" to "Public (No Login Required)".
timurrrr accepted this revision.Oct 8 2014, 11:12 AM
timurrrr edited edge metadata.

r219327!

This revision is now accepted and ready to land.Oct 8 2014, 11:12 AM
timurrrr closed this revision.Oct 8 2014, 11:12 AM

Revision Contents

PathSize
lib/
CodeGen/
AsmPrinter/
2 lines
MC/
3 lines
test/
DebugInfo/
COFF/
2 lines
2 lines
6 lines
2 lines
MC/
COFF/
2 lines

Diff 14515

lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp

Show First 20 Lines • Show All 160 Lines • ▼ Show 20 Linesvoid WinCodeViewLineTables::emitDebugInfoForFunction(const Function *GV) {
MCSymbol *SubsectionBegin = Asm->MMI->getContext().CreateTempSymbol(), MCSymbol *SubsectionBegin = Asm->MMI->getContext().CreateTempSymbol(),
*SubsectionEnd = Asm->MMI->getContext().CreateTempSymbol(); *SubsectionEnd = Asm->MMI->getContext().CreateTempSymbol();
EmitLabelDiff(Asm->OutStreamer, SubsectionBegin, SubsectionEnd); EmitLabelDiff(Asm->OutStreamer, SubsectionBegin, SubsectionEnd);
Asm->OutStreamer.EmitLabel(SubsectionBegin); Asm->OutStreamer.EmitLabel(SubsectionBegin);
// Identify the function this subsection is for. // Identify the function this subsection is for.
Asm->OutStreamer.EmitCOFFSecRel32(Fn); Asm->OutStreamer.EmitCOFFSecRel32(Fn);
Asm->OutStreamer.EmitCOFFSectionIndex(Fn); Asm->OutStreamer.EmitCOFFSectionIndex(Fn);
// Padding after 16-bit section index
timurrrrUnsubmitted
Not Done
ReplyInline Actions

nit: after a 16-bit section index

timurrrr: nit: `after a 16-bit section index`
Asm->EmitInt16(0);
// Length of the function's code, in bytes. // Length of the function's code, in bytes.
EmitLabelDiff(Asm->OutStreamer, Fn, FI.End); EmitLabelDiff(Asm->OutStreamer, Fn, FI.End);
// PC-to-linenumber lookup table: // PC-to-linenumber lookup table:
MCSymbol *FileSegmentEnd = nullptr; MCSymbol *FileSegmentEnd = nullptr;
for (size_t J = 0, F = FI.Instrs.size(); J != F; ++J) { for (size_t J = 0, F = FI.Instrs.size(); J != F; ++J) {
MCSymbol *Instr = FI.Instrs[J]; MCSymbol *Instr = FI.Instrs[J];
▲ Show 20 Lines • Show All 159 Lines • Show Last 20 Lines

lib/MC/WinCOFFStreamer.cpp

Show First 20 Lines • Show All 156 Lines • ▼ Show 20 Linesvoid MCWinCOFFStreamer::EndCOFFSymbolDef() {
CurSymbol = nullptr; CurSymbol = nullptr;
} }
void MCWinCOFFStreamer::EmitCOFFSectionIndex(MCSymbol const *Symbol) { void MCWinCOFFStreamer::EmitCOFFSectionIndex(MCSymbol const *Symbol) {
MCDataFragment *DF = getOrCreateDataFragment(); MCDataFragment *DF = getOrCreateDataFragment();
const MCSymbolRefExpr *SRE = MCSymbolRefExpr::Create(Symbol, getContext()); const MCSymbolRefExpr *SRE = MCSymbolRefExpr::Create(Symbol, getContext());
MCFixup Fixup = MCFixup::Create(DF->getContents().size(), SRE, FK_SecRel_2); MCFixup Fixup = MCFixup::Create(DF->getContents().size(), SRE, FK_SecRel_2);
DF->getFixups().push_back(Fixup); DF->getFixups().push_back(Fixup);
DF->getContents().resize(DF->getContents().size() + 4, 0); // +2, not +4: unlike 32-bit SECREL, SECTION is 16-bit
timurrrrUnsubmitted
Not Done
ReplyInline Actions

Wording: please use just

// Unlike 32-bit SECREL, section index is just 16-bit.
timurrrr: Wording: please use just // Unlike 32-bit SECREL, section index is just 16-bit.
DF->getContents().resize(DF->getContents().size() + 2, 0);
} }
void MCWinCOFFStreamer::EmitCOFFSecRel32(MCSymbol const *Symbol) { void MCWinCOFFStreamer::EmitCOFFSecRel32(MCSymbol const *Symbol) {
MCDataFragment *DF = getOrCreateDataFragment(); MCDataFragment *DF = getOrCreateDataFragment();
const MCSymbolRefExpr *SRE = MCSymbolRefExpr::Create(Symbol, getContext()); const MCSymbolRefExpr *SRE = MCSymbolRefExpr::Create(Symbol, getContext());
MCFixup Fixup = MCFixup::Create(DF->getContents().size(), SRE, FK_SecRel_4); MCFixup Fixup = MCFixup::Create(DF->getContents().size(), SRE, FK_SecRel_4);
DF->getFixups().push_back(Fixup); DF->getFixups().push_back(Fixup);
DF->getContents().resize(DF->getContents().size() + 4, 0); DF->getContents().resize(DF->getContents().size() + 4, 0);
▲ Show 20 Lines • Show All 93 Lines • Show Last 20 Lines

test/DebugInfo/COFF/asm.ll

Show All 22 Lines
; ;
; X86-LABEL: .section .debug$S,"rd" ; X86-LABEL: .section .debug$S,"rd"
; X86-NEXT: .long 4 ; X86-NEXT: .long 4
; X86-NEXT: .long 242 ; X86-NEXT: .long 242
; X86-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]] ; X86-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]]
; X86-NEXT: [[F2_START]]: ; X86-NEXT: [[F2_START]]:
; X86-NEXT: .secrel32 _f ; X86-NEXT: .secrel32 _f
; X86-NEXT: .secidx _f ; X86-NEXT: .secidx _f
; X86-NEXT: .short 0
; X86-NEXT: .long [[END_OF_F]]-_f ; X86-NEXT: .long [[END_OF_F]]-_f
; X86-NEXT: [[FILE_SEGMENT_START:[^:]*]]: ; X86-NEXT: [[FILE_SEGMENT_START:[^:]*]]:
; X86-NEXT: .long 0 ; X86-NEXT: .long 0
; X86-NEXT: .long 3 ; X86-NEXT: .long 3
; X86-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]] ; X86-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]]
; X86-NEXT: .long [[ASM_LINE]]-_f ; X86-NEXT: .long [[ASM_LINE]]-_f
; X86-NEXT: .long 4 ; X86-NEXT: .long 4
; X86-NEXT: .long [[CALL_LINE]]-_f ; X86-NEXT: .long [[CALL_LINE]]-_f
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines
; ;
; X64-LABEL: .section .debug$S,"rd" ; X64-LABEL: .section .debug$S,"rd"
; X64-NEXT: .long 4 ; X64-NEXT: .long 4
; X64-NEXT: .long 242 ; X64-NEXT: .long 242
; X64-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]] ; X64-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]]
; X64-NEXT: [[F2_START]]: ; X64-NEXT: [[F2_START]]:
; X64-NEXT: .secrel32 f ; X64-NEXT: .secrel32 f
; X64-NEXT: .secidx f ; X64-NEXT: .secidx f
; X64-NEXT: .short 0
; X64-NEXT: .long [[END_OF_F]]-f ; X64-NEXT: .long [[END_OF_F]]-f
; X64-NEXT: [[FILE_SEGMENT_START:[^:]*]]: ; X64-NEXT: [[FILE_SEGMENT_START:[^:]*]]:
; X64-NEXT: .long 0 ; X64-NEXT: .long 0
; X64-NEXT: .long 4 ; X64-NEXT: .long 4
; X64-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]] ; X64-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]]
; X64-NEXT: .long [[START]]-f ; X64-NEXT: .long [[START]]-f
; X64-NEXT: .long 3 ; X64-NEXT: .long 3
; X64-NEXT: .long [[ASM_LINE]]-f ; X64-NEXT: .long [[ASM_LINE]]-f
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines

test/DebugInfo/COFF/multifile.ll

Show All 29 Lines
; ;
; X86-LABEL: .section .debug$S,"rd" ; X86-LABEL: .section .debug$S,"rd"
; X86-NEXT: .long 4 ; X86-NEXT: .long 4
; X86-NEXT: .long 242 ; X86-NEXT: .long 242
; X86-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]] ; X86-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]]
; X86-NEXT: [[F2_START]]: ; X86-NEXT: [[F2_START]]:
; X86-NEXT: .secrel32 _f ; X86-NEXT: .secrel32 _f
; X86-NEXT: .secidx _f ; X86-NEXT: .secidx _f
; X86-NEXT: .short 0
; X86-NEXT: .long [[END_OF_F]]-_f ; X86-NEXT: .long [[END_OF_F]]-_f
; Segment for file 'D:\\one.c' begins ; Segment for file 'D:\\one.c' begins
; X86-NEXT: [[FILE_SEGMENT_START:[^:]*]]: ; X86-NEXT: [[FILE_SEGMENT_START:[^:]*]]:
; X86-NEXT: .long 0 ; X86-NEXT: .long 0
; X86-NEXT: .long 1 ; X86-NEXT: .long 1
; X86-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]] ; X86-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]]
; X86-NEXT: .long [[CALL_LINE_1]]-_f ; X86-NEXT: .long [[CALL_LINE_1]]-_f
; X86-NEXT: .long 1 ; X86-NEXT: .long 1
▲ Show 20 Lines • Show All 78 Lines • ▼ Show 20 Lines
; ;
; X64-LABEL: .section .debug$S,"rd" ; X64-LABEL: .section .debug$S,"rd"
; X64-NEXT: .long 4 ; X64-NEXT: .long 4
; X64-NEXT: .long 242 ; X64-NEXT: .long 242
; X64-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]] ; X64-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]]
; X64-NEXT: [[F2_START]]: ; X64-NEXT: [[F2_START]]:
; X64-NEXT: .secrel32 f ; X64-NEXT: .secrel32 f
; X64-NEXT: .secidx f ; X64-NEXT: .secidx f
; X64-NEXT: .short 0
; X64-NEXT: .long [[END_OF_F]]-f ; X64-NEXT: .long [[END_OF_F]]-f
; Segment for file 'D:\\input.c' begins ; Segment for file 'D:\\input.c' begins
; X64-NEXT: [[FILE_SEGMENT_START:[^:]*]]: ; X64-NEXT: [[FILE_SEGMENT_START:[^:]*]]:
; X64-NEXT: .long 0 ; X64-NEXT: .long 0
; X64-NEXT: .long 1 ; X64-NEXT: .long 1
; X64-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]] ; X64-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]]
; X64-NEXT: .long [[START]]-f ; X64-NEXT: .long [[START]]-f
; X64-NEXT: .long 3 ; X64-NEXT: .long 3
▲ Show 20 Lines • Show All 118 Lines • Show Last 20 Lines

test/DebugInfo/COFF/multifunction.ll

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines
; X86-LABEL: .section .debug$S,"rd" ; X86-LABEL: .section .debug$S,"rd"
; X86-NEXT: .long 4 ; X86-NEXT: .long 4
; Line table subsection for x ; Line table subsection for x
; X86-NEXT: .long 242 ; X86-NEXT: .long 242
; X86-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]] ; X86-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]]
; X86-NEXT: [[F2_START]]: ; X86-NEXT: [[F2_START]]:
; X86-NEXT: .secrel32 _x ; X86-NEXT: .secrel32 _x
; X86-NEXT: .secidx _x ; X86-NEXT: .secidx _x
; X86-NEXT: .short 0
; X86-NEXT: .long [[END_OF_X]]-_x ; X86-NEXT: .long [[END_OF_X]]-_x
; X86-NEXT: [[FILE_SEGMENT_START:[^:]*]]: ; X86-NEXT: [[FILE_SEGMENT_START:[^:]*]]:
; X86-NEXT: .long 0 ; X86-NEXT: .long 0
; X86-NEXT: .long 2 ; X86-NEXT: .long 2
; X86-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]] ; X86-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]]
; X86-NEXT: .long [[X_CALL]]-_x ; X86-NEXT: .long [[X_CALL]]-_x
; X86-NEXT: .long 4 ; X86-NEXT: .long 4
; X86-NEXT: .long [[X_RETURN]]-_x ; X86-NEXT: .long [[X_RETURN]]-_x
; X86-NEXT: .long 5 ; X86-NEXT: .long 5
; X86-NEXT: [[FILE_SEGMENT_END]]: ; X86-NEXT: [[FILE_SEGMENT_END]]:
; X86-NEXT: [[F2_END]]: ; X86-NEXT: [[F2_END]]:
; Line table subsection for y ; Line table subsection for y
; X86-NEXT: .long 242 ; X86-NEXT: .long 242
; X86-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]] ; X86-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]]
; X86-NEXT: [[F2_START]]: ; X86-NEXT: [[F2_START]]:
; X86-NEXT: .secrel32 _y ; X86-NEXT: .secrel32 _y
; X86-NEXT: .secidx _y ; X86-NEXT: .secidx _y
; X86-NEXT: .short 0
; X86-NEXT: .long [[END_OF_Y]]-_y ; X86-NEXT: .long [[END_OF_Y]]-_y
; X86-NEXT: [[FILE_SEGMENT_START:[^:]*]]: ; X86-NEXT: [[FILE_SEGMENT_START:[^:]*]]:
; X86-NEXT: .long 0 ; X86-NEXT: .long 0
; X86-NEXT: .long 2 ; X86-NEXT: .long 2
; X86-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]] ; X86-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]]
; X86-NEXT: .long [[Y_CALL]]-_y ; X86-NEXT: .long [[Y_CALL]]-_y
; X86-NEXT: .long 8 ; X86-NEXT: .long 8
; X86-NEXT: .long [[Y_RETURN]]-_y ; X86-NEXT: .long [[Y_RETURN]]-_y
; X86-NEXT: .long 9 ; X86-NEXT: .long 9
; X86-NEXT: [[FILE_SEGMENT_END]]: ; X86-NEXT: [[FILE_SEGMENT_END]]:
; X86-NEXT: [[F2_END]]: ; X86-NEXT: [[F2_END]]:
; Line table subsection for f ; Line table subsection for f
; X86-NEXT: .long 242 ; X86-NEXT: .long 242
; X86-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]] ; X86-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]]
; X86-NEXT: [[F2_START]]: ; X86-NEXT: [[F2_START]]:
; X86-NEXT: .secrel32 _f ; X86-NEXT: .secrel32 _f
; X86-NEXT: .secidx _f ; X86-NEXT: .secidx _f
; X86-NEXT: .short 0
; X86-NEXT: .long [[END_OF_F]]-_f ; X86-NEXT: .long [[END_OF_F]]-_f
; X86-NEXT: [[FILE_SEGMENT_START:[^:]*]]: ; X86-NEXT: [[FILE_SEGMENT_START:[^:]*]]:
; X86-NEXT: .long 0 ; X86-NEXT: .long 0
; X86-NEXT: .long 4 ; X86-NEXT: .long 4
; X86-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]] ; X86-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]]
; X86-NEXT: .long [[F_CALLS_X]]-_f ; X86-NEXT: .long [[F_CALLS_X]]-_f
; X86-NEXT: .long 12 ; X86-NEXT: .long 12
; X86-NEXT: .long [[F_CALLS_Y]]-_f ; X86-NEXT: .long [[F_CALLS_Y]]-_f
▲ Show 20 Lines • Show All 100 Lines • ▼ Show 20 Lines
; X64-LABEL: .section .debug$S,"rd" ; X64-LABEL: .section .debug$S,"rd"
; X64-NEXT: .long 4 ; X64-NEXT: .long 4
; Line table subsection for x ; Line table subsection for x
; X64-NEXT: .long 242 ; X64-NEXT: .long 242
; X64-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]] ; X64-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]]
; X64-NEXT: [[F2_START]]: ; X64-NEXT: [[F2_START]]:
; X64-NEXT: .secrel32 x ; X64-NEXT: .secrel32 x
; X64-NEXT: .secidx x ; X64-NEXT: .secidx x
; X64-NEXT: .short 0
; X64-NEXT: .long [[END_OF_X]]-x ; X64-NEXT: .long [[END_OF_X]]-x
; X64-NEXT: [[FILE_SEGMENT_START:[^:]*]]: ; X64-NEXT: [[FILE_SEGMENT_START:[^:]*]]:
; X64-NEXT: .long 0 ; X64-NEXT: .long 0
; X64-NEXT: .long 3 ; X64-NEXT: .long 3
; X64-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]] ; X64-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]]
; X64-NEXT: .long [[X_START]]-x ; X64-NEXT: .long [[X_START]]-x
; X64-NEXT: .long 3 ; X64-NEXT: .long 3
; X64-NEXT: .long [[X_CALL_LINE]]-x ; X64-NEXT: .long [[X_CALL_LINE]]-x
; X64-NEXT: .long 4 ; X64-NEXT: .long 4
; X64-NEXT: .long [[X_EPILOG_AND_RET]]-x ; X64-NEXT: .long [[X_EPILOG_AND_RET]]-x
; X64-NEXT: .long 5 ; X64-NEXT: .long 5
; X64-NEXT: [[FILE_SEGMENT_END]]: ; X64-NEXT: [[FILE_SEGMENT_END]]:
; X64-NEXT: [[F2_END]]: ; X64-NEXT: [[F2_END]]:
; Line table subsection for y ; Line table subsection for y
; X64-NEXT: .long 242 ; X64-NEXT: .long 242
; X64-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]] ; X64-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]]
; X64-NEXT: [[F2_START]]: ; X64-NEXT: [[F2_START]]:
; X64-NEXT: .secrel32 y ; X64-NEXT: .secrel32 y
; X64-NEXT: .secidx y ; X64-NEXT: .secidx y
; X64-NEXT: .short 0
; X64-NEXT: .long [[END_OF_Y]]-y ; X64-NEXT: .long [[END_OF_Y]]-y
; X64-NEXT: [[FILE_SEGMENT_START:[^:]*]]: ; X64-NEXT: [[FILE_SEGMENT_START:[^:]*]]:
; X64-NEXT: .long 0 ; X64-NEXT: .long 0
; X64-NEXT: .long 3 ; X64-NEXT: .long 3
; X64-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]] ; X64-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]]
; X64-NEXT: .long [[Y_START]]-y ; X64-NEXT: .long [[Y_START]]-y
; X64-NEXT: .long 7 ; X64-NEXT: .long 7
; X64-NEXT: .long [[Y_CALL_LINE]]-y ; X64-NEXT: .long [[Y_CALL_LINE]]-y
; X64-NEXT: .long 8 ; X64-NEXT: .long 8
; X64-NEXT: .long [[Y_EPILOG_AND_RET]]-y ; X64-NEXT: .long [[Y_EPILOG_AND_RET]]-y
; X64-NEXT: .long 9 ; X64-NEXT: .long 9
; X64-NEXT: [[FILE_SEGMENT_END]]: ; X64-NEXT: [[FILE_SEGMENT_END]]:
; X64-NEXT: [[F2_END]]: ; X64-NEXT: [[F2_END]]:
; Line table subsection for f ; Line table subsection for f
; X64-NEXT: .long 242 ; X64-NEXT: .long 242
; X64-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]] ; X64-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]]
; X64-NEXT: [[F2_START]]: ; X64-NEXT: [[F2_START]]:
; X64-NEXT: .secrel32 f ; X64-NEXT: .secrel32 f
; X64-NEXT: .secidx f ; X64-NEXT: .secidx f
; X64-NEXT: .short 0
; X64-NEXT: .long [[END_OF_F]]-f ; X64-NEXT: .long [[END_OF_F]]-f
; X64-NEXT: [[FILE_SEGMENT_START:[^:]*]]: ; X64-NEXT: [[FILE_SEGMENT_START:[^:]*]]:
; X64-NEXT: .long 0 ; X64-NEXT: .long 0
; X64-NEXT: .long 5 ; X64-NEXT: .long 5
; X64-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]] ; X64-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]]
; X64-NEXT: .long [[F_START]]-f ; X64-NEXT: .long [[F_START]]-f
; X64-NEXT: .long 11 ; X64-NEXT: .long 11
; X64-NEXT: .long [[F_CALLS_X]]-f ; X64-NEXT: .long [[F_CALLS_X]]-f
▲ Show 20 Lines • Show All 122 Lines • Show Last 20 Lines

test/DebugInfo/COFF/simple.ll

Show All 20 Lines
; ;
; X86-LABEL: .section .debug$S,"rd" ; X86-LABEL: .section .debug$S,"rd"
; X86-NEXT: .long 4 ; X86-NEXT: .long 4
; X86-NEXT: .long 242 ; X86-NEXT: .long 242
; X86-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]] ; X86-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]]
; X86-NEXT: [[F2_START]]: ; X86-NEXT: [[F2_START]]:
; X86-NEXT: .secrel32 _f ; X86-NEXT: .secrel32 _f
; X86-NEXT: .secidx _f ; X86-NEXT: .secidx _f
; X86-NEXT: .short 0
; X86-NEXT: .long [[END_OF_F]]-_f ; X86-NEXT: .long [[END_OF_F]]-_f
; X86-NEXT: [[FILE_SEGMENT_START:[^:]*]]: ; X86-NEXT: [[FILE_SEGMENT_START:[^:]*]]:
; X86-NEXT: .long 0 ; X86-NEXT: .long 0
; X86-NEXT: .long 2 ; X86-NEXT: .long 2
; X86-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]] ; X86-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]]
; X86-NEXT: .long [[CALL_LINE]]-_f ; X86-NEXT: .long [[CALL_LINE]]-_f
; X86-NEXT: .long 4 ; X86-NEXT: .long 4
; X86-NEXT: .long [[RETURN_STMT]]-_f ; X86-NEXT: .long [[RETURN_STMT]]-_f
▲ Show 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
; ;
; X64-LABEL: .section .debug$S,"rd" ; X64-LABEL: .section .debug$S,"rd"
; X64-NEXT: .long 4 ; X64-NEXT: .long 4
; X64-NEXT: .long 242 ; X64-NEXT: .long 242
; X64-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]] ; X64-NEXT: .long [[F2_END:.*]]-[[F2_START:.*]]
; X64-NEXT: [[F2_START]]: ; X64-NEXT: [[F2_START]]:
; X64-NEXT: .secrel32 f ; X64-NEXT: .secrel32 f
; X64-NEXT: .secidx f ; X64-NEXT: .secidx f
; X64-NEXT: .short 0
; X64-NEXT: .long [[END_OF_F]]-f ; X64-NEXT: .long [[END_OF_F]]-f
; X64-NEXT: [[FILE_SEGMENT_START:[^:]*]]: ; X64-NEXT: [[FILE_SEGMENT_START:[^:]*]]:
; X64-NEXT: .long 0 ; X64-NEXT: .long 0
; X64-NEXT: .long 3 ; X64-NEXT: .long 3
; X64-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]] ; X64-NEXT: .long [[FILE_SEGMENT_END:.*]]-[[FILE_SEGMENT_START]]
; X64-NEXT: .long [[START]]-f ; X64-NEXT: .long [[START]]-f
; X64-NEXT: .long 3 ; X64-NEXT: .long 3
; X64-NEXT: .long [[CALL_LINE]]-f ; X64-NEXT: .long [[CALL_LINE]]-f
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines

test/MC/COFF/secidx.s

// RUN: llvm-mc -filetype=obj -triple i686-pc-win32 %s | llvm-readobj -s -sr | FileCheck %s // RUN: llvm-mc -filetype=obj -triple i686-pc-win32 %s | llvm-readobj -s -sr | FileCheck %s
// check that we produce the correct relocation for .secidx // check that we produce the correct relocation for .secidx
Lfoo: Lfoo:
.secidx Lfoo .secidx Lfoo
.secidx Lbar .secidx Lbar
timurrrrUnsubmitted
Not Done
ReplyInline Actions

I suggest we add .short 0 between these as we've yet to see a .secidx directive which is not 4-byte aligned (right?).

timurrrr: I suggest we add `.short 0` between these as we've yet to see a `.secidx` directive which is…
.section spam .section spam
Lbar: Lbar:
ret ret
// CHECK: Relocations [ // CHECK: Relocations [
// CHECK-NEXT: 0x0 IMAGE_REL_I386_SECTION .text // CHECK-NEXT: 0x0 IMAGE_REL_I386_SECTION .text
// CHECK-NEXT: 0x4 IMAGE_REL_I386_SECTION spam // CHECK-NEXT: 0x2 IMAGE_REL_I386_SECTION spam
// CHECK-NEXT: ] // CHECK-NEXT: ]