This is an archive of the discontinued LLVM Phabricator instance.

Add "typedef T value_type;" to llvm::Optional<T>.
ClosedPublic

Authored by jordan_rose on Sep 26 2014, 11:49 AM.

Details

Reviewers
dblaikie
Summary

For convenience. No functionality change.

Diff Detail

Event Timeline

jordan_rose retitled this revision from to Add "typedef T value_type;" to llvm::Optional<T>..
jordan_rose updated this object.
jordan_rose edited the test plan for this revision. (Show Details)
jordan_rose added a reviewer: dblaikie.
jordan_rose added a subscriber: Unknown Object (MLST).
dblaikie accepted this revision.Sep 26 2014, 11:50 AM
dblaikie edited edge metadata.

I assume this is part of std::experimental::optional?

Looks good to me, especially if that's the case.

This revision is now accepted and ready to land.Sep 26 2014, 11:50 AM
jordan_rose closed this revision.Sep 29 2014, 12:06 PM

That's correct. Committed as r218617.