Add support for intercepting functions from msvcr110.dll

[• ehsan]

Summary

This finishes support for ASAN on MSVC2012.

[timurrrr]

Formatting nit, otherwise LGTM.

lib/interception/interception_win.cc

186 ↗

(On Diff #14079)

I'd much rather prefer something like

const char *InterestingDLLs[] = { "kernel32.dll",
                                  "msvcr110.dll", // VS2012
                                  "msvcr120.dll", // VS2013
                                  NULL };

or

const char *InterestingDLLs[] = {
  "kernel32.dll",
  "msvcr110.dll", // VS2012
  "msvcr120.dll", // VS2013
  NULL };

[please pick the version that clang-format likes more]
especially given the naming confusion (VS11=VS2012, VS12=VS2013).

What do you think?

[• ehsan]

Sounds good. clang-format seems to prefer the former so I will commit that.

[• ehsan]

Closed by commit rL218465 (authored by @ehsan).

compiler-rt/trunk/lib/interception/interception_win.cc

#endif
   // Restore the original permissions.
   if (!VirtualProtect((void *)old_bytes, head, old_prot, &unused_prot))
     return false;  // not clear if this failure bothers us.
 
   return true;
 }
 
 static const void **InterestingDLLsAvailable() {
-  const char *InterestingDLLs[] = { "kernel32.dll", "msvcr120.dll", NULL };
+  const char *InterestingDLLs[] = {"kernel32.dll",
+                                   "msvcr110.dll", // VS2012
+                                   "msvcr120.dll", // VS2013
+                                   NULL};
   static void *result[ARRAY_SIZE(InterestingDLLs)] = { 0 };
   if (!result[0]) {
     for (size_t i = 0, j = 0; InterestingDLLs[i]; ++i) {
       if (HMODULE h = GetModuleHandleA(InterestingDLLs[i]))
         result[j++] = (void *)h;
     }
   }
   return (const void **)&result[0];