This is an archive of the discontinued LLVM Phabricator instance.

Specify libc++abi location with cmake variable
AbandonedPublic

Authored by lisyarus on Sep 25 2014, 9:40 AM.

Details

Summary

Trying to build libc++ with libc++abi, I was surprised that, although there exists a cmake variable to specify location of libc++abi includes (LIBCXX_LIBCXXABI_INCLUDE_PATHS), there is no way to provide the location of libc++abi.so.
I suggest adding a variable LIBCXX_LIBCXXABI_LIBRARY for that purpose.

Diff Detail

Event Timeline

lisyarus updated this revision to Diff 14065.Sep 25 2014, 9:40 AM
lisyarus retitled this revision from to Specify libc++abi location with cmake variable.
lisyarus updated this object.
lisyarus edited the test plan for this revision. (Show Details)
lisyarus added reviewers: EricWF, mclow.lists, danalbert.
lisyarus added a subscriber: Unknown Object (MLST).
EricWF edited edge metadata.Sep 25 2014, 9:42 AM

I currently have a patch out for review that adds support for things like this but for all ABI libraries.
Could you please take a look and see if that meets your use case?

http://reviews.llvm.org/D5038

Yes, it looks like your patch fixes this issue.

lisyarus planned changes to this revision.Sep 26 2014, 1:29 AM
lisyarus abandoned this revision.