This is an archive of the discontinued LLVM Phabricator instance.

Fix float division-by-zero in R600 scheduler
ClosedPublic

Authored by samsonov on Sep 15 2014, 11:08 AM.

Details

Reviewers
vljn
samsonov
Summary

Fix a float division by zero reported by UBSan. It was reported
in the following test cases:

LLVM :: CodeGen/R600/and.ll
LLVM :: CodeGen/R600/fma.ll
LLVM :: CodeGen/R600/xor.ll

I'm not sure is actually an accepted value for ALUFetchRationEstimate,
or we should add an assert and fix a bug elsewhere. Please take a look.

Diff Detail

Event Timeline

samsonov updated this revision to Diff 13722.Sep 15 2014, 11:08 AM
samsonov retitled this revision from to Fix float division-by-zero in R600 scheduler.
samsonov updated this object.
samsonov edited the test plan for this revision. (Show Details)
samsonov added a reviewer: vljn.
samsonov added a subscriber: Unknown Object (MLST).
samsonov accepted this revision.Sep 17 2014, 10:57 AM
samsonov added a reviewer: samsonov.

Submitted as r217967, thanks!

This revision is now accepted and ready to land.Sep 17 2014, 10:57 AM
samsonov closed this revision.Sep 17 2014, 10:57 AM