This is an archive of the discontinued LLVM Phabricator instance.

Avoid calling strtoll and atoll in asan_str_test.cc on Windows for now
ClosedPublic

Authored by ehsan on Sep 13 2014, 8:08 AM.

Details

Summary

These two functions are unavailable on MSVC2012, which breaks building the
ASAN tests with MSVC2012. Since the tests required to run these functions
are disabled on Windows for now, avoid building them to fix the MSVC2012
builds.

Diff Detail

Repository
rL LLVM

Event Timeline

ehsan updated this revision to Diff 13675.Sep 13 2014, 8:08 AM
ehsan retitled this revision from to Avoid calling strtoll and atoll in asan_str_test.cc on Windows for now.
ehsan updated this object.
ehsan edited the test plan for this revision. (Show Details)
ehsan added a reviewer: timurrrr.
ehsan added a subscriber: Unknown Object (MLST).
timurrrr accepted this revision.Sep 15 2014, 3:33 AM
timurrrr edited edge metadata.

LGTM, thanks!

This revision is now accepted and ready to land.Sep 15 2014, 3:33 AM
ehsan closed this revision.Sep 15 2014, 4:44 AM
ehsan updated this revision to Diff 13702.

Closed by commit rL217763 (authored by @ehsan).