[asan-assembly-instrumentation] Added end-to-end test for proper stack unwind for functions with inline assembly.

[ygorshenin]

Summary

[asan-assembly-instrumentation] Added end-to-end test for proper stack unwind for functions with inline assembly.

[eugenis]

Can you make it a lit test?
Also, you don't really need deep recursion. It's enough to check that 1 unwind step in the asm block works.
Again, in 2 cases - with and without a frame pointer (btw, this is something that's very easy to do in lit tests).

[ygorshenin]

Added lit test for stack unwind.

[ygorshenin]

PTAL

[ygorshenin]

Fixed compilation flags + plafrom specification for the lit test.

[eugenis]

LGTM, thanks

test/asan/TestCases/Linux/asan-asm-stacktrace-test.cc

14 ↗

(On Diff #13520)

I think attributes are usually placed before the return type.

[ygorshenin]

Function attribute is moved before return type.

[ygorshenin]

Many thanks!

test/asan/TestCases/Linux/asan-asm-stacktrace-test.cc

14 ↗

(On Diff #13520)

Done.

[ygorshenin]

Closed by commit rL217487 (authored by @ygorshenin).

compiler-rt/trunk/test/asan/TestCases/Linux/asan-asm-stacktrace-test.cc

+// Check that a stack unwinding algorithm works corretly even with the assembly
+// instrumentation.
+
+// REQUIRES: x86_64-supported-target,i386-supported-target
+// RUN: %clangxx_asan -g -O1 %s -fno-inline-functions -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -mllvm -asan-instrument-assembly -o %t && not %run %t 2>&1 | FileCheck %s
+// RUN: %clangxx_asan -g -O1 %s -fno-inline-functions -fomit-frame-pointer -momit-leaf-frame-pointer -mllvm -asan-instrument-assembly -o %t && not %run %t 2>&1 | FileCheck %s
+
+#include <cstddef>
+
+// CHECK: READ of size 4
+// CHECK: {{#0 0x[0-9a-fA-F]+ in foo}}
+// CHECK: {{#1 0x[0-9a-fA-F]+ in main}}
+
+__attribute__((noinline)) int foo(size_t n, int *buffer) {
+  int r;
+  __asm__("movl (%[buffer], %[n], 4), %[r]  \n\t"
+          : [r] "=r"(r)
+          : [buffer] "r"(buffer), [n] "r"(n)
+          : "memory");
+  return r;
+}
+
+int main() {
+  const size_t n = 16;
+  int *buffer = new int[n];
+  foo(n, buffer);
+  delete[] buffer;
+  return 0;
+}