This is an archive of the discontinued LLVM Phabricator instance.

[mips] Marked the Trap-on-Condition instructions as Mips II
ClosedPublic

Authored by ehostunreach on Sep 3 2014, 9:21 AM.

Diff Detail

Event Timeline

ehostunreach retitled this revision from to [mips] Marked the Trap-on-Condition instructions as Mips II.
ehostunreach updated this object.
ehostunreach edited the test plan for this revision. (Show Details)
ehostunreach added a reviewer: dsanders.
dsanders edited edge metadata.Sep 4 2014, 2:11 AM

This will LGTM with a couple test changes.

At the moment, all the new tests use $0 and $3. Could you change a couple of them just to confirm that the encoding varies correctly?

Could you also add tests for the 3-operand form of teq, etc.? For example, 'teq $0, $3, 1234'. It looks like they were missed out when I generated these tests.

ehostunreach edited edge metadata.

Added 3-operand form of teq,tge,... etc. and changed the operands of the
instructions in order to test different encodings.

dsanders accepted this revision.Sep 5 2014, 7:49 AM
dsanders edited edge metadata.

LGTM

This revision is now accepted and ready to land.Sep 5 2014, 7:49 AM
dsanders closed this revision.Sep 5 2014, 8:59 AM