Allow redirection to pts for POSIX process

[zephyr]

Summary

I'm using lldb as a lib and I need to redirect inferior stdin/out/err to my own pts.
However, I find that, if the path matches with "/dev/pts/", it will be changed to NULL.
One workaround is to make symbolic link sto my dev/pts/x to bypass the problem.

The attached patch provides a fix for the issue.

[zephyr]

Relevant discussion:

http://lists.cs.uiuc.edu/pipermail/lldb-dev/2014-March/003737.html

[tfiala]

I tried running the tests with this change on Ubuntu 14.04 x86_64 (via 'ninja check-lldb' on a cmake/ninja build). The tests appear to be locked up.

Can you verify your change with the test suite, zephyr? Thanks!

[zephyr]

Hi Todd,

I'm sorry for the issue. It's a stupid error. Fixed in patchset 2. On my x86-64, ninja check-lldb shows
FAILED (errors=5, skipped=5)
Ran 309 tests.

it matches the output without my change.

[tfiala]

No worries, trying this again with patch set 2.

[tfiala]

LGTM.

Tested:
Ubuntu 14.04 x86_64, clang-3.5-built lldb.

[tfiala]

Submitted here:

svn commit
Sending        source/Plugins/Process/POSIX/ProcessPOSIX.cpp
Sending        source/Plugins/Process/POSIX/ProcessPOSIX.h
Transmitting file data ..
Committed revision 217382.

source/Plugins/Process/POSIX/ProcessPOSIX.h

     ProcessMonitor &
     GetMonitor() { assert(m_monitor); return *m_monitor; }
 
-    const char *GetFilePath(const lldb_private::FileAction *file_action, const char *default_path);
+    const char *GetFilePath(const lldb_private::FileAction *file_action, const char *default_path,
+                            const char *dbg_pts_path);
 
     /// Stops all threads in the process.
     /// The \p stop_tid parameter indicates the thread which initiated the stop.

source/Plugins/Process/POSIX/ProcessPOSIX.cpp

 }
 
 const char *
-ProcessPOSIX::GetFilePath(const lldb_private::FileAction *file_action, const char *default_path)
+ProcessPOSIX::GetFilePath(const lldb_private::FileAction *file_action, const char *default_path,
+                          const char *dbg_pts_path)
 {
-    const char *pts_name = "/dev/pts/";
     const char *path = NULL;
 
     if (file_action)

             // (/dev/pts). If so, convert to using a different default path
             // instead to redirect I/O to the debugger console. This should
             //  also handle user overrides to /dev/null or a different file.
-            if (!path || ::strncmp(path, pts_name, ::strlen(pts_name)) == 0)
+            if (!path || (dbg_pts_path &&
+                          ::strncmp(path, dbg_pts_path, ::strlen(dbg_pts_path)) == 0))
                 path = default_path;
         }
     }
-
     return path;
 }
 

     const char *stdout_path = NULL;
     const char *stderr_path = NULL;
 
+    const char * dbg_pts_path = launch_info.GetPTY().GetSlaveName(NULL,0);
+
     file_action = launch_info.GetFileActionForFD (STDIN_FILENO);
-    stdin_path = GetFilePath(file_action, stdin_path);
+    stdin_path = GetFilePath(file_action, stdin_path, dbg_pts_path);
 
     file_action = launch_info.GetFileActionForFD (STDOUT_FILENO);
-    stdout_path = GetFilePath(file_action, stdout_path);
+    stdout_path = GetFilePath(file_action, stdout_path, dbg_pts_path);
 
     file_action = launch_info.GetFileActionForFD (STDERR_FILENO);
-    stderr_path = GetFilePath(file_action, stderr_path);
+    stderr_path = GetFilePath(file_action, stderr_path, dbg_pts_path);
 
     m_monitor = new ProcessMonitor (this, 
                                     module,