This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] type_info support for MSVC
AbandonedPublic

Authored by K-ballo on Aug 29 2014, 4:37 PM.

Details

Summary

Adds type_info support for MSVC. Note that it is expected in the global namespace.

I have implemented some of the member functions in exception.cpp because they have a dependency on string or cstring. Suggestions on how to implement them inline are welcomed (note no __builtin_strcmp in MSVC).

Diff Detail

Event Timeline

K-ballo updated this revision to Diff 13118.Aug 29 2014, 4:37 PM
K-ballo retitled this revision from to [libcxx] type_info support for MSVC.
K-ballo updated this object.
K-ballo edited the test plan for this revision. (Show Details)
K-ballo added reviewers: mclow.lists, EricWF.
K-ballo added a subscriber: Unknown Object (MLST).
majnemer added inline comments.
include/typeinfo
164–165

This name isn't demangled. We can't call UnDecorateSymbolName, it's only available if dbghelp.dll is present.

Perhaps libc++abi should have a demangler?

K-ballo added inline comments.Aug 29 2014, 7:32 PM
include/typeinfo
164–165

Should it be demangled? It is a lot of trouble for little benefit, given that the implementation is conformant as is.

Waiting for VS2015RTM

K-ballo abandoned this revision.Oct 12 2017, 4:12 PM