This is an archive of the discontinued LLVM Phabricator instance.

lldb Missing break statement added
ClosedPublic

Authored by pawelo on Aug 26 2014, 11:06 AM.

Reviewers

tfiala

Summary

This is very small thing, still I couldn't resist creating a fix for this.

pawelo retitled this revision from to lldb Missing break statement added.

pawelo updated this object.

pawelo edited the test plan for this revision. (Show Details)

pawelo set the repository for this revision to rL LLVM.

pawelo added a subscriber: Unknown Object (MLST).

As Greg already called out, LGTM.

Just giving it a test run on MacOSX, then will check in.

Tested:
MacOSX 10.9.4, Xcode6-Beta6-built lldb.

This revision is now accepted and ready to land.Aug 27 2014, 9:21 AM

svn commit
Sending source/Plugins/Process/Utility/StopInfoMachException.cpp
Transmitting file data .
Committed revision 216554.

Path

Size

source/

Plugins/

Process/

Utility/

1 line

Show First 20 Lines • Show All 462 Lines • ▼ Show 20 Lines	// }
}		}
// EXC_ARM_DA_DEBUG seems to be reused for EXC_BREAKPOINT as well as EXC_BAD_ACCESS		// EXC_ARM_DA_DEBUG seems to be reused for EXC_BREAKPOINT as well as EXC_BAD_ACCESS
if (thread.GetTemporaryResumeState() == eStateStepping)		if (thread.GetTemporaryResumeState() == eStateStepping)
return StopInfo::CreateStopReasonToTrace(thread);		return StopInfo::CreateStopReasonToTrace(thread);
}		}
// It looks like exc_sub_code has the 4 bytes of the instruction that triggered the		// It looks like exc_sub_code has the 4 bytes of the instruction that triggered the
// exception, i.e. our breakpoint opcode		// exception, i.e. our breakpoint opcode
is_actual_breakpoint = exc_code == 1;		is_actual_breakpoint = exc_code == 1;
		break;
}		}

default:		default:
break;		break;
}		}

if (is_actual_breakpoint)		if (is_actual_breakpoint)
{		{
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines