This is an archive of the discontinued LLVM Phabricator instance.

[ASan] Rename the ASan dynamic RT
ClosedPublic

Authored by timurrrr on Aug 22 2014, 7:51 AM.

Details

Reviewers
kcc
samsonov
Summary

While working on PR20214 [-MD CRT support on Windows] it turned out that we use the same base name for static and shared/dynamic runtimes.
This doesn't work well on Windows as creating ABC.DLL automatically creates an import library called ABC.LIB which makes CMake crazy.

Diff Detail

Event Timeline

timurrrr updated this revision to Diff 12842.Aug 22 2014, 7:51 AM
timurrrr retitled this revision from to [ASan] Rename the ASan dynamic RT.
timurrrr updated this object.
timurrrr edited the test plan for this revision. (Show Details)
timurrrr added reviewers: samsonov, kcc.
timurrrr added subscribers: Unknown Object (MLST), Unknown Object (MLST).
samsonov accepted this revision.Aug 22 2014, 1:40 PM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 22 2014, 1:40 PM
timurrrr closed this revision.Aug 25 2014, 4:53 AM

r216380, thanks!