Page MenuHomePhabricator

Fix OpenCL Work-Item function arguments in Polly

Authored by franz on Jul 10 2018, 6:58 AM.



Work-Item related OpenCL functions usually return size_t type, which is different for 64bit and 32bit SPIR IR. Polly used i32 type everywhere, causing it to fail on assertions.

Also changes the dimension to be always i32 type.

Diff Detail

rPLO Polly

Event Timeline

franz created this revision.Jul 10 2018, 6:58 AM

What's the relationship between this and D48774?

alaindenzler added a subscriber: alaindenzler.EditedJul 10 2018, 7:13 AM

Sorry Michal, I already submitted this patch a week ago.. see D48774

Edit: The patch in D48774 is based on this patch, but with testcase and comments

franz abandoned this revision.Jul 10 2018, 7:33 AM

Alain, OK i wasn't aware. Apologies for confusion, i'll close this

Sorry guys. Alain just started to look into this last week and we wanted to get him up-to-speed before getting in touch with you. I should have helped to coordinate better. I asked Alain to discuss with you which / what patches are still needed.