This is an archive of the discontinued LLVM Phabricator instance.

Fix clang Makefile build with libxml2 enabled and CPPFLAGS is passed in
Needs ReviewPublic

Authored by loladiro on Aug 13 2014, 5:17 PM.

This revision needs review, but there are no reviewers specified.

Summary

When building clang, we pass in CPPFLAGS via the command line, which (I believe) makes this not work. CPP.Flags works nicely to get around this.

loladiro retitled this revision from to Fix clang Makefile build with libxml2 enabled and CPPFLAGS is passed in.

loladiro updated this object.

loladiro edited the test plan for this revision. (Show Details)

loladiro set the repository for this revision to rL LLVM.

loladiro added a subscriber: Unknown Object (MLST).

bump

bump^3 ;).

Path

Size

tools/

c-index-test/

13 lines

	Show All 28 Lines
	USEDLIBS = clang.a \			USEDLIBS = clang.a \
	clangIndex.a clangFormat.a clangRewrite.a \			clangIndex.a clangFormat.a clangRewrite.a \
	clangFrontend.a clangDriver.a \			clangFrontend.a clangDriver.a \
	clangTooling.a \			clangTooling.a \
	clangSerialization.a clangParse.a clangSema.a \			clangSerialization.a clangParse.a clangSema.a \
	clangAnalysis.a clangEdit.a clangAST.a clangLex.a \			clangAnalysis.a clangEdit.a clangAST.a clangLex.a \
	clangBasic.a			clangBasic.a

	include $(CLANG_LEVEL)/Makefile

	LIBS += $(LIBXML2_LIBS)

	# Headers in $(LIBXML2_INC) should not be checked with clang's -Wdocumentation.			# Headers in $(LIBXML2_INC) should not be checked with clang's -Wdocumentation.
	# Use -isystem instead of -I then.			# Use -isystem instead of -I then.
	# FIXME: Could autoconf detect clang or availability of -isystem?			# FIXME: Could autoconf detect clang or availability of -isystem?
	ifneq ($(findstring -Wdocumentation,$(OPTIMIZE_OPTION)),)			ifneq ($(findstring -Wdocumentation,$(OPTIMIZE_OPTION)),)
	CPPFLAGS += $(subst -I,-isystem ,$(LIBXML2_INC))			CPP.Flags += $(subst -I,-isystem ,$(LIBXML2_INC))
	else			else
	CPPFLAGS += $(LIBXML2_INC)			CPP.Flags += $(LIBXML2_INC)
	endif			endif

				include $(CLANG_LEVEL)/Makefile

				LIBS = $(LIBXML2_LIBS)