The support is limited to signed modulo access expressions with a constant right hand side, e.g., A[i % 2]. Test cases are modified according to this new feature and two new test cases to test the functionality are added. A test case for not yet supported modulo conditions is added too.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
I have some stylistic comments inline, the rest looks good to me.
| lib/Analysis/ScopInfo.cpp | ||
|---|---|---|
| 179 ↗ | (On Diff #12403) | capture |
| 188 ↗ | (On Diff #12403) | Here 'auto' is ok, because I can infer the type from the context on the same line (imho). |
| 191 ↗ | (On Diff #12403) | I would use the type here instead of 'auto'. |
| 192 ↗ | (On Diff #12403) | I would use the type here instead of 'auto'. |
| 311 ↗ | (On Diff #12403) | Now you're not using 'auto', why? |
| lib/Support/SCEVValidator.cpp | ||
| 161 ↗ | (On Diff #12403) | capture |
| 172 ↗ | (On Diff #12403) | I would use the type here. |
| 379 ↗ | (On Diff #12403) | Consistency: auto? |
Comment Actions
Thanks for the feedback,.. you're right all the time, I should be more consistent.
I'll fix everything and commit it then.