This is an archive of the discontinued LLVM Phabricator instance.

[LIT] Move display of unsupported and xfail tests to summary.
ClosedPublic

Authored by EricWF on Aug 10 2014, 3:26 PM.

Download Raw Diff

Details

Reviewers

EricWF
• ddunbar

Commits

rG5ccd9e029f2b: [LIT] Move display of unsupported and xfail tests to summary.
rL215809: [LIT] Move display of unsupported and xfail tests to summary.

Summary

This patch changes the way xfail and unsupported tests are displayed.
This output is only displayed when the --show-unsupported/--show-xfail flags are passed to lit.

Currently xfail/unsupported tests are printed during the run of the test-suite. I think its better to display this information during the summary instead.
This patch removes the printing of these tests from when they are run to the summary.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 12337.Aug 10 2014, 3:26 PM

EricWF retitled this revision from to [LIT] Move display of unsupported and xfail tests to summary. .

EricWF updated this object.

EricWF edited the test plan for this revision. (Show Details)

EricWF added a reviewer: • ddunbar.

EricWF set the repository for this revision to rL LLVM.

EricWF added a subscriber: Unknown Object (MLST).

ping.

I agree, makes more sense. LGTM

Daniel

Accepting.

This revision is now accepted and ready to land.Aug 15 2014, 4:19 PM

EricWF closed this revision.Aug 15 2014, 4:20 PM

Revision Contents

Path

Size

utils/

lit/

main.py

11 lines

Diff 12337

utils/lit/lit/main.py

Context not available.
	test.getFullName())	test.getFullName())

	shouldShow = test.result.code.isFailure or \	shouldShow = test.result.code.isFailure or \
	(self.opts.show_unsupported and test.result.code.name == 'UNSUPPORTED') or \
	(self.opts.show_xfail and test.result.code.name == 'XFAIL') or \
	(not self.opts.quiet and not self.opts.succinct)	(not self.opts.quiet and not self.opts.succinct)
	if not shouldShow:	if not shouldShow:
	return	return
Context not available.
	# Print each test in any of the failing groups.	# Print each test in any of the failing groups.
	for title,code in (('Unexpected Passing Tests', lit.Test.XPASS),	for title,code in (('Unexpected Passing Tests', lit.Test.XPASS),
	('Failing Tests', lit.Test.FAIL),	('Failing Tests', lit.Test.FAIL),
	('Unresolved Tests', lit.Test.UNRESOLVED)):	('Unresolved Tests', lit.Test.UNRESOLVED),
		('Unsupported Tests', lit.Test.UNSUPPORTED),
		('Expected Failing Tests', lit.Test.XFAIL)):
		if (lit.Test.XFAIL == code and not opts.show_xfail) or \
		(lit.Test.UNSUPPORTED == code and not opts.show_unsupported):
		continue
	elts = byCode.get(code)	elts = byCode.get(code)
	if not elts:	if not elts:
	continue	continue
Context not available.
	('Unsupported Tests ', lit.Test.UNSUPPORTED),	('Unsupported Tests ', lit.Test.UNSUPPORTED),
	('Unresolved Tests ', lit.Test.UNRESOLVED),	('Unresolved Tests ', lit.Test.UNRESOLVED),
	('Unexpected Passes ', lit.Test.XPASS),	('Unexpected Passes ', lit.Test.XPASS),
	('Unexpected Failures', lit.Test.FAIL),):	('Unexpected Failures', lit.Test.FAIL)):
	if opts.quiet and not code.isFailure:	if opts.quiet and not code.isFailure:
	continue	continue
	N = len(byCode.get(code,[]))	N = len(byCode.get(code,[]))
Context not available.