This is an archive of the discontinued LLVM Phabricator instance.

Differential D4750

[lit] Add --show-xfail flag to LIT.
ClosedPublic

Authored by EricWF on Jul 31 2014, 11:57 PM.

Details

Reviewers
EricWF
• ddunbar
Commits
rGc85f00a0622d: [lit] Add --show-xfail flag to LIT.
rL214609: [lit] Add --show-xfail flag to LIT.
Summary

This patch add a --show-xfail flag. If this flag is specified then each xfail test will be printed to output.
When it is not given xfail tests are ignored. Ignoring xfail tests is the current behavior.

This flag is meant to mirror the --show-unsupported flag that was recently added.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 12095.Jul 31 2014, 11:57 PM
EricWF retitled this revision from to [lit] Add --show-xfail flag to LIT..
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added a reviewer: • ddunbar.
EricWF set the repository for this revision to rL LLVM.
EricWF added a subscriber: Unknown Object (MLST).
• ddunbar edited edge metadata.Aug 1 2014, 9:47 AM

LGTM

  • Daniel
EricWF accepted this revision.Aug 1 2014, 6:38 PM
EricWF added a reviewer: EricWF.

Accepting to make arc play nice.

This revision is now accepted and ready to land.Aug 1 2014, 6:38 PM
EricWF closed this revision.Aug 1 2014, 6:38 PM

Revision Contents

PathSize
docs/
CommandGuide/
4 lines
utils/
lit/
lit/
4 lines

Diff 12095

docs/CommandGuide/lit.rst

Context not available.
Show the names of unsupported tests. Show the names of unsupported tests.
.. option:: --show-xfail
Show the names of tests that were expected to fail.
.. _execution-options: .. _execution-options:
EXECUTION OPTIONS EXECUTION OPTIONS
Context not available.

utils/lit/lit/main.py

Context not available.
shouldShow = test.result.code.isFailure or \ shouldShow = test.result.code.isFailure or \
(self.opts.show_unsupported and test.result.code.name == 'UNSUPPORTED') or \ (self.opts.show_unsupported and test.result.code.name == 'UNSUPPORTED') or \
(self.opts.show_xfail and test.result.code.name == 'XFAIL') or \
(not self.opts.quiet and not self.opts.succinct) (not self.opts.quiet and not self.opts.succinct)
if not shouldShow: if not shouldShow:
return return
Context not available.
group.add_option("", "--show-unsupported", dest="show_unsupported", group.add_option("", "--show-unsupported", dest="show_unsupported",
help="Show unsupported tests", help="Show unsupported tests",
action="store_true", default=False) action="store_true", default=False)
group.add_option("", "--show-xfail", dest="show_xfail",
help="Show tests that were expected to fail",
action="store_true", default=False)
parser.add_option_group(group) parser.add_option_group(group)
group = OptionGroup(parser, "Test Execution") group = OptionGroup(parser, "Test Execution")
Context not available.