Page MenuHomePhabricator

Change the encoding of the triple string in the GDB-RSP from hex bytes to plain text
ClosedPublic

Authored by mg11 on Jul 29 2014, 6:18 AM.

Details

Summary

I changed the presentation of the triple's data to plain text in the GDBRemoteCommunicationServer.cpp, and modified it's decoding in GDBRemoteCommunicationClient.cpp accordingly. Have updated documentation in lldb-gdb-remote.txt to suit.

The rationale behind this change can be followed in http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20140721/011948.html.

Diff Detail

Repository
rL LLVM

Event Timeline

mg11 updated this revision to Diff 11977.Jul 29 2014, 6:18 AM
mg11 retitled this revision from to Change the encoding of the triple string in the GDB-RSP from hex bytes to plain text.
mg11 updated this object.
mg11 edited the test plan for this revision. (Show Details)
mg11 added a reviewer: tfiala.
tfiala edited edge metadata.Jul 31 2014, 6:08 AM

Looks good, Matthew. If you can make sure that the tests run clean, that'd
be great. (I'm at an airport sans computer...)

Thanks!

-Todd

mg11 added a comment.Jul 31 2014, 6:11 AM

Thanks Todd!

Don't worry - I ran a linux test run with the python suite and I tested
lldb <-> lldb-debugserver interaction. Was fine.

have a good holiday!

Matt

Todd Fiala wrote:

Looks good, Matthew. If you can make sure that the tests run clean,
that'd be great. (I'm at an airport sans computer...)

Thanks!

-Todd

Thanks much! Also the second message was meant to go to the non-review
thread but early-morning coffee deprivation has taken its toll :-)

mg11 closed this revision.Jul 31 2014, 10:21 PM
mg11 updated this revision to Diff 12094.

Closed by commit rL214480 (authored by @mg11).