This is an archive of the discontinued LLVM Phabricator instance.

[mips] Add support for -mfpxx and -mno-fpxx.
ClosedPublic

Authored by dsanders on Jul 10 2014, 8:25 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

dsanders updated this revision to Diff 11275.Jul 10 2014, 8:25 AM
dsanders retitled this revision from to [mips] Add support for -mfpxx and -mno-fpxx..
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
dsanders added a reviewer: atanasyan.
dsanders added a subscriber: mpf.
atanasyan accepted this revision.Jul 10 2014, 8:46 AM
atanasyan edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jul 10 2014, 8:46 AM
dsanders updated this revision to Diff 11356.Jul 13 2014, 11:21 AM
dsanders edited edge metadata.

After further manual testing (in particular comparing objects between GAS and
Clang) it became necessary to rewrite the patch. I think this will need
re-review before I commit.

Removed -mno-fpxx since it doesn't exist in other tools.
-mfpxx now implies -mno-odd-spreg.

dsanders closed this revision.Jul 16 2014, 3:06 AM
dsanders closed this revision.Jul 16 2014, 3:06 AM
dsanders updated this revision to Diff 11491.

Closed by commit rL213132 (authored by @dsanders).