This is an archive of the discontinued LLVM Phabricator instance.

Differential D4330

[libcxx] Fix typo in __compressed_pair that caused swap to incorrectly deduce noexcept
ClosedPublic

Authored by EricWF on Jun 27 2014, 1:28 PM.

Details

Reviewers
mclow.lists
Summary

This seems like a simple copy paste error.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 10944.Jun 27 2014, 1:28 PM
EricWF retitled this revision from to [libcxx] Fix typo in __compressed_pair that caused swap to incorrectly deduce noexcept.
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF set the repository for this revision to rL LLVM.
EricWF added a subscriber: Unknown Object (MLST).
EricWF edited the test plan for this revision. (Show Details)Jun 27 2014, 3:43 PM
EricWF edited the test plan for this revision. (Show Details)Jun 27 2014, 6:29 PM
EricWF added a reviewer: mclow.lists.
EricWF set the repository for this revision to rL LLVM.
mclow.lists accepted this revision.Jun 30 2014, 8:43 AM
mclow.lists edited edge metadata.

Committed as revision 212046. Thanks for the bug report - and the fix!

This revision is now accepted and ready to land.Jun 30 2014, 8:43 AM
EricWF closed this revision.Jun 30 2014, 1:53 PM

Revision Contents

PathSize
include/
12 lines

Diff 10944

include/memory

Context not available.
_LIBCPP_INLINE_VISIBILITY void swap(__libcpp_compressed_pair_imp& __x) _LIBCPP_INLINE_VISIBILITY void swap(__libcpp_compressed_pair_imp& __x)
_NOEXCEPT_(__is_nothrow_swappable<_T1>::value && _NOEXCEPT_(__is_nothrow_swappable<_T1>::value &&
__is_nothrow_swappable<_T1>::value) __is_nothrow_swappable<_T2>::value)
{ {
using _VSTD::swap; using _VSTD::swap;
swap(__first_, __x.__first_); swap(__first_, __x.__first_);
Context not available.
_LIBCPP_INLINE_VISIBILITY void swap(__libcpp_compressed_pair_imp& __x) _LIBCPP_INLINE_VISIBILITY void swap(__libcpp_compressed_pair_imp& __x)
_NOEXCEPT_(__is_nothrow_swappable<_T1>::value && _NOEXCEPT_(__is_nothrow_swappable<_T1>::value &&
__is_nothrow_swappable<_T1>::value) __is_nothrow_swappable<_T2>::value)
{ {
using _VSTD::swap; using _VSTD::swap;
swap(__second_, __x.__second_); swap(__second_, __x.__second_);
Context not available.
_LIBCPP_INLINE_VISIBILITY void swap(__libcpp_compressed_pair_imp& __x) _LIBCPP_INLINE_VISIBILITY void swap(__libcpp_compressed_pair_imp& __x)
_NOEXCEPT_(__is_nothrow_swappable<_T1>::value && _NOEXCEPT_(__is_nothrow_swappable<_T1>::value &&
__is_nothrow_swappable<_T1>::value) __is_nothrow_swappable<_T2>::value)
{ {
using _VSTD::swap; using _VSTD::swap;
swap(__first_, __x.__first_); swap(__first_, __x.__first_);
Context not available.
_LIBCPP_INLINE_VISIBILITY void swap(__libcpp_compressed_pair_imp&) _LIBCPP_INLINE_VISIBILITY void swap(__libcpp_compressed_pair_imp&)
_NOEXCEPT_(__is_nothrow_swappable<_T1>::value && _NOEXCEPT_(__is_nothrow_swappable<_T1>::value &&
__is_nothrow_swappable<_T1>::value) __is_nothrow_swappable<_T2>::value)
{ {
} }
}; };
Context not available.
_LIBCPP_INLINE_VISIBILITY void swap(__compressed_pair& __x) _LIBCPP_INLINE_VISIBILITY void swap(__compressed_pair& __x)
_NOEXCEPT_(__is_nothrow_swappable<_T1>::value && _NOEXCEPT_(__is_nothrow_swappable<_T1>::value &&
__is_nothrow_swappable<_T1>::value) __is_nothrow_swappable<_T2>::value)
{base::swap(__x);} {base::swap(__x);}
}; };
Context not available.
void void
swap(__compressed_pair<_T1, _T2>& __x, __compressed_pair<_T1, _T2>& __y) swap(__compressed_pair<_T1, _T2>& __x, __compressed_pair<_T1, _T2>& __y)
_NOEXCEPT_(__is_nothrow_swappable<_T1>::value && _NOEXCEPT_(__is_nothrow_swappable<_T1>::value &&
__is_nothrow_swappable<_T1>::value) __is_nothrow_swappable<_T2>::value)
{__x.swap(__y);} {__x.swap(__y);}
// __same_or_less_cv_qualified // __same_or_less_cv_qualified
Context not available.