This is an archive of the discontinued LLVM Phabricator instance.

Differential D4051

[SeparateConstOffsetFromGEP] make two tests more strict
ClosedPublic

Authored by jingyue on Jun 6 2014, 4:10 PM.

Details

Reviewers
eliben
meheff
Summary

inbounds are not necessary in these two tests. zext(a +nuw b) = zext(a) +
zext(b) should hold with or without inbounds.

Diff Detail

Event Timeline

jingyue updated this revision to Diff 10197.Jun 6 2014, 4:10 PM
jingyue retitled this revision from to [SeparateConstOffsetFromGEP] make two tests more strict.
jingyue updated this object.
jingyue edited the test plan for this revision. (Show Details)
jingyue added reviewers: eliben, meheff.
jingyue added a subscriber: Unknown Object (MLST).
Herald added a subscriber: jholewinski. · View Herald TranscriptJun 6 2014, 4:10 PM
meheff accepted this revision.Jun 8 2014, 10:00 AM
meheff edited edge metadata.
meheff added inline comments.
test/Transforms/SeparateConstOffsetFromGEP/NVPTX/split-gep.ll
76

nit: in the comment the variable is a, in the code it is b.

81

same here: a/b mismatch.

This revision is now accepted and ready to land.Jun 8 2014, 10:00 AM
jingyue closed this revision.Jun 8 2014, 1:10 PM

Thanks Mark!

Fixed the mismatches and committed it in r210437

Revision Contents

PathSize
test/
Transforms/
SeparateConstOffsetFromGEP/
NVPTX/
4 lines

Diff 10197

test/Transforms/SeparateConstOffsetFromGEP/NVPTX/split-gep.ll

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines
; Verifies we handle nested sext/zext correctly. ; Verifies we handle nested sext/zext correctly.
define void @sext_zext(i32 %a, i32 %b, float** %out1, float** %out2) { define void @sext_zext(i32 %a, i32 %b, float** %out1, float** %out2) {
entry: entry:
%0 = add nsw nuw i32 %a, 1 %0 = add nsw nuw i32 %a, 1
%1 = sext i32 %0 to i48 %1 = sext i32 %0 to i48
%2 = zext i48 %1 to i64 ; zext(sext(a +nsw nuw 1)) = zext(sext(a)) + 1 %2 = zext i48 %1 to i64 ; zext(sext(a +nsw nuw 1)) = zext(sext(a)) + 1
%3 = add nsw i32 %b, 2 %3 = add nsw i32 %b, 2
%4 = sext i32 %3 to i48 %4 = sext i32 %3 to i48
%5 = zext i48 %4 to i64 ; zext(sext(a +nsw 2)) != zext(sext(a)) + 2 %5 = zext i48 %4 to i64 ; zext(sext(a +nsw 2)) != zext(sext(a)) + 2
meheffUnsubmitted
Not Done
ReplyInline Actions

nit: in the comment the variable is a, in the code it is b.

meheff: nit: in the comment the variable is a, in the code it is b.
%p1 = getelementptr inbounds [32 x [32 x float]]* @float_2d_array, i64 0, i64 %2, i64 %5 %p1 = getelementptr [32 x [32 x float]]* @float_2d_array, i64 0, i64 %2, i64 %5
store float* %p1, float** %out1 store float* %p1, float** %out1
%6 = add nuw i32 %a, 3 %6 = add nuw i32 %a, 3
%7 = zext i32 %6 to i48 %7 = zext i32 %6 to i48
%8 = sext i48 %7 to i64 ; sext(zext(b +nuw 3)) = zext(b +nuw 3) = zext(b) + 3 %8 = sext i48 %7 to i64 ; sext(zext(b +nuw 3)) = zext(b +nuw 3) = zext(b) + 3
meheffUnsubmitted
Not Done
ReplyInline Actions

same here: a/b mismatch.

meheff: same here: a/b mismatch.
%9 = add nsw i32 %b, 4 %9 = add nsw i32 %b, 4
%10 = zext i32 %9 to i48 %10 = zext i32 %9 to i48
%11 = sext i48 %10 to i64 ; sext(zext(b +nsw 4)) != zext(b) + 4 %11 = sext i48 %10 to i64 ; sext(zext(b +nsw 4)) != zext(b) + 4
%p2 = getelementptr inbounds [32 x [32 x float]]* @float_2d_array, i64 0, i64 %8, i64 %11 %p2 = getelementptr [32 x [32 x float]]* @float_2d_array, i64 0, i64 %8, i64 %11
store float* %p2, float** %out2 store float* %p2, float** %out2
ret void ret void
} }
; CHECK-LABEL: @sext_zext( ; CHECK-LABEL: @sext_zext(
; CHECK: [[BASE_PTR_1:%[a-zA-Z0-9]+]] = getelementptr [32 x [32 x float]]* @float_2d_array, i64 0, i64 %{{[a-zA-Z0-9]+}}, i64 %{{[a-zA-Z0-9]+}} ; CHECK: [[BASE_PTR_1:%[a-zA-Z0-9]+]] = getelementptr [32 x [32 x float]]* @float_2d_array, i64 0, i64 %{{[a-zA-Z0-9]+}}, i64 %{{[a-zA-Z0-9]+}}
; CHECK: getelementptr float* [[BASE_PTR_1]], i64 32 ; CHECK: getelementptr float* [[BASE_PTR_1]], i64 32
; CHECK: [[BASE_PTR_2:%[a-zA-Z0-9]+]] = getelementptr [32 x [32 x float]]* @float_2d_array, i64 0, i64 %{{[a-zA-Z0-9]+}}, i64 %{{[a-zA-Z0-9]+}} ; CHECK: [[BASE_PTR_2:%[a-zA-Z0-9]+]] = getelementptr [32 x [32 x float]]* @float_2d_array, i64 0, i64 %{{[a-zA-Z0-9]+}}, i64 %{{[a-zA-Z0-9]+}}
; CHECK: getelementptr float* [[BASE_PTR_2]], i64 96 ; CHECK: getelementptr float* [[BASE_PTR_2]], i64 96
▲ Show 20 Lines • Show All 141 Lines • Show Last 20 Lines