This is an archive of the discontinued LLVM Phabricator instance.

Differential D3975

Objects defined in the current module that don't have an explicit alignment get the preferred alignment, not the ABI alignment. Add test case that shouldn't warn.
Needs ReviewPublic

Authored by jlerouge on May 30 2014, 5:39 PM.

Details

Reviewers
baldrick

Diff Detail

Event Timeline

jlerouge updated this revision to Diff 9974.May 30 2014, 5:39 PM
jlerouge retitled this revision from to Objects defined in the current module that don't have an explicit alignment get the preferred alignment, not the ABI alignment. Add test case that shouldn't warn..
jlerouge updated this object.
jlerouge edited the test plan for this revision. (Show Details)
jlerouge added a reviewer: baldrick.Jun 25 2014, 7:47 PM

Revision Contents

PathSize
lib/
Analysis/
2 lines
test/
Analysis/
Lint/
10 lines

Diff 9974

lib/Analysis/Lint.cpp

Show First 20 Lines • Show All 432 Lines • ▼ Show 20 Lines if (AllocaInst *AI = dyn_cast<AllocaInst>(Base)) {
// If the global may be defined differently in another compilation unit // If the global may be defined differently in another compilation unit
// then don't warn about funky memory accesses. // then don't warn about funky memory accesses.
if (GV->hasDefinitiveInitializer()) { if (GV->hasDefinitiveInitializer()) {
Type *GTy = GV->getType()->getElementType(); Type *GTy = GV->getType()->getElementType();
if (DL && GTy->isSized()) if (DL && GTy->isSized())
BaseSize = DL->getTypeAllocSize(GTy); BaseSize = DL->getTypeAllocSize(GTy);
BaseAlign = GV->getAlignment(); BaseAlign = GV->getAlignment();
if (DL && BaseAlign == 0 && GTy->isSized()) if (DL && BaseAlign == 0 && GTy->isSized())
BaseAlign = DL->getABITypeAlignment(GTy); BaseAlign = DL->getPreferredAlignment(GV);
} }
} }
// Accesses from before the start or after the end of the object are not // Accesses from before the start or after the end of the object are not
// defined. // defined.
Assert1(Size == AliasAnalysis::UnknownSize || Assert1(Size == AliasAnalysis::UnknownSize ||
BaseSize == AliasAnalysis::UnknownSize || BaseSize == AliasAnalysis::UnknownSize ||
(Offset >= 0 && Offset + Size <= BaseSize), (Offset >= 0 && Offset + Size <= BaseSize),
▲ Show 20 Lines • Show All 270 Lines • Show Last 20 Lines

test/Analysis/Lint/global-align.ll

  • This file was added.
; RUN: opt -lint -disable-output < %s
target datalayout = "e-m:o-p:32:32-i1:8:32-i8:8:32-i16:16:32-f64:32:64-v64:32:64-v128:32:128-a:0:32-n32-S32"
@gval = internal unnamed_addr global i1 false
define i32 @test() nounwind ssp{
%x = load i1* @gval, align 4
%y = zext i1 %x to i32
ret i32 %y
}