This is an archive of the discontinued LLVM Phabricator instance.

Improve vDSO check in AsanCheckDynamicRTPrereqs
ClosedPublic

Authored by ygribov on May 26 2014, 6:05 AM.

Reviewers

kcc
eugenis

Summary

Some kernels seem to provide non-empty DT_SONAME for vDSO. Take care of that when verifying library order.

ygribov retitled this revision from to Improve vDSO check in AsanCheckDynamicRTPrereqs.

ygribov updated this object.

ygribov edited the test plan for this revision. (Show Details)

ygribov added a subscriber: Unknown Object (MLST).

Ping.

LGTM

This revision is now accepted and ready to land.Jun 2 2014, 3:45 AM

r210012.

Path

Size

lib/

asan/

4 lines

	Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines
	void AsanCheckIncompatibleRT() {}			void AsanCheckIncompatibleRT() {}
	#else			#else
	static int FindFirstDSOCallback(struct dl_phdr_info *info, size_t size,			static int FindFirstDSOCallback(struct dl_phdr_info *info, size_t size,
	void *data) {			void *data) {
	// Continue until the first dynamic library is found			// Continue until the first dynamic library is found
	if (!info->dlpi_name \|\| info->dlpi_name[0] == 0)			if (!info->dlpi_name \|\| info->dlpi_name[0] == 0)
	return 0;			return 0;

				// Ignore vDSO
				if (internal_strncmp(info->dlpi_name, "linux-", sizeof("linux-") - 1) == 0)
				return 0;

	(const char *)data = info->dlpi_name;			(const char *)data = info->dlpi_name;
	return 1;			return 1;
	}			}

	static bool IsDynamicRTName(const char *libname) {			static bool IsDynamicRTName(const char *libname) {
	return internal_strstr(libname, "libclang_rt.asan") \|\|			return internal_strstr(libname, "libclang_rt.asan") \|\|
	internal_strstr(libname, "libasan.so");			internal_strstr(libname, "libasan.so");
	}			}
	▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines