This is an archive of the discontinued LLVM Phabricator instance.

Add specialization of FoldingSetTrait for std::pair.
ClosedPublic

Authored by klimek on May 23 2014, 6:08 AM.

Details

Reviewers
jordan_rose
Summary

Needed for clang's static analyzer. Jordan suggested to add it directly
in FoldingSet.h.

Diff Detail

Event Timeline

klimek updated this revision to Diff 9754.May 23 2014, 6:08 AM
klimek retitled this revision from to Add specialization of FoldingSetTrait for std::pair..
klimek updated this object.
klimek edited the test plan for this revision. (Show Details)
klimek added a reviewer: jordan_rose.
klimek added a subscriber: Unknown Object (MLST).
jordan_rose edited edge metadata.May 23 2014, 10:06 AM

Hm. This doesn't look like it will actually handle pairs containing any non-struct type, where you have to use AddInteger or AddPointer as appropriate. (Why don't those have FoldingSetTraits directly?)

jordan_rose accepted this revision.Jun 13 2014, 10:12 AM
jordan_rose edited edge metadata.

It looks like there's already a specialization for T*, so it's just the integers that get left out. Someone can add those later if they need them.

This revision is now accepted and ready to land.Jun 13 2014, 10:12 AM
klimek closed this revision.Jun 15 2014, 7:51 AM

Thx, submitted as r210990.