This is an archive of the discontinued LLVM Phabricator instance.

Added support of X86::CMOVE instruction to the assembly instrumentation.
AbandonedPublic

Authored by ygorshenin on May 20 2014, 4:25 AM.

Details

Reviewers
eugenis
Summary

Added support of X86::CMOVE instruction to the assembly instrumentation.

Diff Detail

Event Timeline

ygorshenin updated this revision to Diff 9608.May 20 2014, 4:25 AM
ygorshenin retitled this revision from to Added support of X86::CMOVE instruction to the assembly instrumentation..
ygorshenin updated this object.
ygorshenin edited the test plan for this revision. (Show Details)
ygorshenin added a reviewer: eugenis.
ygorshenin added a subscriber: Unknown Object (MLST).
eugenis edited edge metadata.May 20 2014, 4:33 AM

What about other variations of cmov?
Why CMOVE*rr? These are register-to-register moves.
I think you need more complex instrumentation for cmov, as memory access is conditional.

Closing the issue, as cmov instructions are not needed for rflags test.

ygorshenin abandoned this revision.May 20 2014, 6:48 AM