[ASan tests] Add the first Windows-only lit test

[timurrrr]

test/asan/TestCases/Windows/thread_stack_array_left_oob.cc

3

Please note: I'm intentionally not filing and issue before I commit this patch to make it much easier for someone working on FileCheck to reproduce.
I'm afraid this issue exists only on Windows...

[samsonov]

w00t, glad to see this coming.

test/asan/TestCases/Windows/thread_stack_array_left_oob.cc

1

Why 2>&1 here?

3

Okay... I would suggest to look at MemoryBuffer::getSTDIN() - FileCheck just uses LLVM libraries.

[timurrrr]

r208802, thanks!

test/asan/TestCases/Windows/thread_stack_array_left_oob.cc

1

Because ASan reports go to stderr? :)

[samsonov]

test/asan/TestCases/Windows/thread_stack_array_left_oob.cc

1

But this line doesn't run ASan executable, it's a compiler invocation.

[timurrrr]

2014-05-14 23:40 GMT+04:00 Alexey Samsonov <[e-mail]>:

+// RUN: %clangxx_asan -O0 %s -Fe%t 2>&1
> > Why 2>&1 here?

Because ASan reports go to stderr? :)

But this line doesn't run ASan executable, it's a compiler invocation.

Oops! Probably a copy-n-paste mistake...
Fixed in r208805.

CMakeLists.txt

   if (MSVC OR XCODE)
     set(LIT_ARGS_DEFAULT "${LIT_ARGS_DEFAULT} --no-progress-bar")
   endif()
   set(LLVM_LIT_ARGS "${LIT_ARGS_DEFAULT}" CACHE STRING "Default options for lit")
 endif()
 
 if("${COMPILER_RT_TEST_COMPILER}" MATCHES "clang[+]*$")
   set(COMPILER_RT_TEST_COMPILER_ID Clang)
+elseif("${COMPILER_RT_TEST_COMPILER}" MATCHES "clang-cl.exe$")
+  set(COMPILER_RT_TEST_COMPILER_ID Clang)
 else()
   set(COMPILER_RT_TEST_COMPILER_ID GNU)
 endif()
 
 string(TOLOWER ${CMAKE_SYSTEM_NAME} COMPILER_RT_OS_DIR)
 set(COMPILER_RT_LIBRARY_OUTPUT_DIR
   ${COMPILER_RT_OUTPUT_DIR}/lib/${COMPILER_RT_OS_DIR})
 set(COMPILER_RT_LIBRARY_INSTALL_DIR

test/asan/TestCases/Windows/lit.local.cfg

+def getRoot(config):
+  if not config.parent:
+    return config
+  return getRoot(config.parent)
+
+root = getRoot(config)
+
+# We only run a small set of tests on Windows for now.
+# Override the parent directory's "unsupported" decision until we can handle
+# all of its tests.
+if root.host_os in ['Windows']:
+  config.unsupported = False
+else:
+  config.unsupported = True

test/asan/TestCases/Windows/thread_stack_array_left_oob.cc

+// RUN: %clangxx_asan -O0 %s -Fe%t 2>&1
+// 'cat' is used below to work around FileCheck buffering bug which makes this
+// test flaky.  FIXME: file an issue.
+// RUN: not %run %t 2>&1 | cat | FileCheck %s --check-prefix=CHECK
+
+#include <windows.h>
+
+DWORD WINAPI thread_proc(void *context) {
+  int subscript = -1;
+  volatile char stack_buffer[42];
+  stack_buffer[subscript] = 42;
+// CHECK: AddressSanitizer: stack-buffer-overflow on address [[ADDR:0x[0-9a-f]+]]
+// CHECK: WRITE of size 1 at [[ADDR]] thread T1
+// CHECK:   {{#0 .* thread_proc .*thread_stack_array_left_oob.cc}}:[[@LINE-3]]
+// CHECK: Address [[ADDR]] is located in stack of thread T1 at offset {{.*}} in frame
+// CHECK:   thread_proc
+  return 0;
+}
+
+int main(void) {
+  HANDLE thr = CreateThread(NULL, 0, thread_proc, NULL, 0, NULL);
+// CHECK: Thread T1 created by T0 here:
+// CHECK:   {{#[01] .* main .*thread_stack_array_left_oob.cc}}:[[@LINE-2]]
+  WaitForSingleObject(thr, INFINITE);
+  return 0;
+}

test/asan/lit.cfg

 if config.compiler_id == 'GNU':
   extra_linkflags = ["-lpthread", "-lstdc++", "-ldl"]
 else:
   extra_linkflags = []
 # Setup default compiler flags used with -fsanitize=address option.
 # FIXME: Review the set of required flags and check if it can be reduced.
 target_cflags = [get_required_attr(config, "target_cflags")] + extra_linkflags
 target_cxxflags = config.cxx_mode_flags + target_cflags
-clang_asan_static_cflags = ["-fsanitize=address",
+clang_asan_static_cflags = ["-fsanitize=address"] + target_cflags
+
+clang_path = getattr(config, 'clang', None)
+if clang_path.find("clang-cl") == -1:
+  clang_asan_static_cflags += ["-g",
                                "-mno-omit-leaf-frame-pointer",
                                "-fno-omit-frame-pointer",
-                            "-fno-optimize-sibling-calls",
-                            "-g"] + target_cflags
+                               "-fno-optimize-sibling-calls"]
+else:
+  clang_asan_static_cflags += ["-Zi",
+                               "-Wno-deprecated-declarations",
+                               "-D_HAS_EXCEPTIONS=0"]
+
 clang_asan_static_cxxflags = config.cxx_mode_flags + clang_asan_static_cflags
 
 if config.asan_dynamic:
   clang_asan_cflags = clang_asan_static_cflags + ['-shared-libasan']
   clang_asan_cxxflags = clang_asan_static_cxxflags + ['-shared-libasan']
   config.available_features.add("asan-dynamic-runtime")
 else:
   clang_asan_cflags = clang_asan_static_cflags

test/lit.common.cfg

 
 # Setup clang binary.
 compiler_path = getattr(config, 'clang', None)
 if (not compiler_path) or (not os.path.exists(compiler_path)):
   lit_config.fatal("Can't find compiler on path %r" % compiler_path)
 
 compiler_id = getattr(config, 'compiler_id', None)
 if compiler_id == "Clang":
+  if platform.system() != 'Windows':
     config.cxx_mode_flags = ["--driver-mode=g++"]
+  else:
+    config.cxx_mode_flags = []
 elif compiler_id == 'GNU':
   config.cxx_mode_flags = ["-x c++"]
 else:
   lit_config.fatal("Unsupported compiler id: %r" % compiler_id)
 
 # Clear some environment variables that might affect Clang.
 possibly_dangerous_env_vars = ['COMPILER_PATH', 'RC_DEBUG_OPTIONS',
                                'CINDEXTEST_PREAMBLE_FILE', 'LIBRARY_PATH',

 
 # Tweak PATH to include llvm tools dir.
 llvm_tools_dir = getattr(config, 'llvm_tools_dir', None)
 if (not llvm_tools_dir) or (not os.path.exists(llvm_tools_dir)):
   lit_config.fatal("Invalid llvm_tools_dir config attribute: %r" % llvm_tools_dir)
 path = os.path.pathsep.join((llvm_tools_dir, config.environment['PATH']))
 config.environment['PATH'] = path
 
+# Help MSVS link.exe find the standard libraries.
+if platform.system() == 'Windows':
+  config.environment['LIB'] = os.environ['LIB']
+
 # Use ugly construction to explicitly prohibit "clang", "clang++" etc.
 # in RUN lines.
 config.substitutions.append(
     (' clang', """\n\n*** Do not use 'clangXXX' in tests,
      instead define '%clangXXX' substitution in lit config. ***\n\n""") )
 
 # Allow tests to be executed on a simulator or remotely.
 config.substitutions.append( ('%run', config.emulator) )