This is an archive of the discontinued LLVM Phabricator instance.

[asan-asm-instrumentation] (SUB|ADD) 128, RSP is replaced by LEA in assembly instrumentation.
ClosedPublic

Authored by ygorshenin on May 7 2014, 10:29 AM.

Details

Reviewers
eugenis
Summary

(SUB|ADD) 128, RSP is replaced by LEA in assembly instrumentation.

Diff Detail

Event Timeline

ygorshenin updated this revision to Diff 9177.May 7 2014, 10:29 AM
ygorshenin retitled this revision from to (SUB|ADD) 128, RSP is replaced by LEA..
ygorshenin updated this object.
ygorshenin edited the test plan for this revision. (Show Details)
ygorshenin added a reviewer: eugenis.
ygorshenin added a subscriber: Unknown Object (MLST).
ygorshenin updated this revision to Diff 9178.May 7 2014, 10:33 AM

Restored LLVM conding style.

eugenis edited edge metadata.May 8 2014, 1:04 AM

Please add a compiler-rt test case (as a separate change).
Reports would be unreadable at this point (without CFI), but it should be possible to have (a) a basic positive test, (b) a test the we preserve flags.

ygorshenin retitled this revision from (SUB|ADD) 128, RSP is replaced by LEA. to [asan-asm-instrumentation] (SUB|ADD) 128, RSP is replaced by LEA in assembly instrumentation..May 8 2014, 1:29 AM
ygorshenin updated this object.
ygorshenin edited edge metadata.
eugenis accepted this revision.May 8 2014, 3:02 AM
eugenis edited edge metadata.

Committed as r208296.

This revision is now accepted and ready to land.May 8 2014, 3:02 AM
eugenis closed this revision.May 8 2014, 3:03 AM