This is an archive of the discontinued LLVM Phabricator instance.

[ASan/Win] Don't crash when ASAN_OPTIONS have disable_core=1
ClosedPublic

Authored by timurrrr on May 5 2014, 8:57 AM.

Download Raw Diff

Details

Reviewers

kcc
timurrrr

Diff Detail

Event Timeline

timurrrr updated this revision to Diff 9079.May 5 2014, 8:57 AM

timurrrr retitled this revision from to [ASan/Win] Don't crash when ASAN_OPTIONS have disable_core=1.

timurrrr updated this object.

timurrrr edited the test plan for this revision. (Show Details)

timurrrr added a reviewer: kcc.

timurrrr added a subscriber: Unknown Object (MLST).

LGTM

r208070.

This revision is now accepted and ready to land.May 6 2014, 1:29 AM

Thanks!

Revision Contents

Path

Size

lib/

asan/

asan_rtl.cc

3 lines

sanitizer_common/

sanitizer_win.cc

2 lines

Diff 9079

lib/asan/asan_rtl.cc

	Show First 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
	"If set, prints ASan exit stats even after program terminates "			"If set, prints ASan exit stats even after program terminates "
	"successfully.");			"successfully.");
	ParseFlag(str, &f->coverage, "coverage",			ParseFlag(str, &f->coverage, "coverage",
	"If set, coverage information will be dumped at program shutdown (if the "			"If set, coverage information will be dumped at program shutdown (if the "
	"coverage instrumentation was enabled at compile time).");			"coverage instrumentation was enabled at compile time).");

	ParseFlag(str, &f->disable_core, "disable_core",			ParseFlag(str, &f->disable_core, "disable_core",
	"Disable core dumping. By default, disable_core=1 on 64-bit to avoid "			"Disable core dumping. By default, disable_core=1 on 64-bit to avoid "
	"dumping a 16T+ core file.");			"dumping a 16T+ core file. "
				"Ignored on architectures that don't dump core by default.");

	ParseFlag(str, &f->allow_reexec, "allow_reexec",			ParseFlag(str, &f->allow_reexec, "allow_reexec",
	"Allow the tool to re-exec the program. This may interfere badly with "			"Allow the tool to re-exec the program. This may interfere badly with "
	"the debugger.");			"the debugger.");

	ParseFlag(str, &f->print_full_thread_history,			ParseFlag(str, &f->print_full_thread_history,
	"print_full_thread_history",			"print_full_thread_history",
	"If set, prints thread creation stacks for the threads involved in the "			"If set, prints thread creation stacks for the threads involved in the "
	▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines

lib/sanitizer_common/sanitizer_win.cc

	Show First 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
	UNIMPLEMENTED();			UNIMPLEMENTED();
	}			}

	void DumpProcessMap() {			void DumpProcessMap() {
	UNIMPLEMENTED();			UNIMPLEMENTED();
	}			}

	void DisableCoreDumper() {			void DisableCoreDumper() {
	UNIMPLEMENTED();			// Do nothing.
	}			}

	void ReExec() {			void ReExec() {
	UNIMPLEMENTED();			UNIMPLEMENTED();
	}			}

	void PrepareForSandboxing() {			void PrepareForSandboxing() {
	// Nothing here for now.			// Nothing here for now.
	▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines