This is an archive of the discontinued LLVM Phabricator instance.

Asm instrumentation is disabled on non-Linux OSes.
ClosedPublic

Authored by ygorshenin on Apr 30 2014, 4:26 AM.

Details

Reviewers
eugenis
Summary

Asm instrumentation is disabled on non-Linux OSes.

Diff Detail

Event Timeline

ygorshenin updated this revision to Diff 8969.Apr 30 2014, 4:26 AM
ygorshenin retitled this revision from to Asm instrumentation is disabled on non-Linux OSes..
ygorshenin updated this object.
ygorshenin edited the test plan for this revision. (Show Details)
ygorshenin added a reviewer: eugenis.
ygorshenin added subscribers: timurrrr, Unknown Object (MLST).
ygorshenin updated this revision to Diff 8970.Apr 30 2014, 4:28 AM

Style fix.

eugenis added inline comments.Apr 30 2014, 5:37 AM
lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp
214

I don't think they will ever be fixed for all known platforms. Do something like
bool hasCompilerRTSupport=T.isOSLinux(); and remove the fixme.

PTAL

lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp
214

Done.

eugenis accepted this revision.Apr 30 2014, 7:11 AM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.Apr 30 2014, 7:11 AM
eugenis closed this revision.Apr 30 2014, 7:11 AM

r207651.