This is an archive of the discontinued LLVM Phabricator instance.

Vectorize intrinsic math function calls in SLPVectorizer
AbandonedPublic

Authored by karthikthecool on Apr 29 2014, 4:25 AM.

Details

Summary

Hi All,
Added a patch to vectorize intrinsic math functions in SLPVectorizer.
If any intrinsic math function can be replaced with llvm intrinsic function we do so after doing the relevent check and vectorize the same if vectorization turns out to be benificial.
This is quite similar to how we handle math functions in LoopVectorizer.

Could you please let me know your inputs on this patch?

Thanks
Karthik Bhat

Diff Detail

Event Timeline

karthikthecool retitled this revision from to Vectorize intrinsic math function calls in SLPVectorizer.
karthikthecool updated this object.
karthikthecool edited the test plan for this revision. (Show Details)
karthikthecool added a subscriber: Unknown Object (MLST).
nadav edited edge metadata.Apr 29 2014, 9:17 AM

Hi Karthik,

I read your patch and I noticed that you moved lots of code into VectorUtils.h. Please split your patch to two parts: 1. the part where you move code around and 2. the part where you add new functionality to the vectorizer. This will make the task of reviewing the patch much easier.

Thanks,
Nadav

karthikthecool abandoned this revision.May 8 2014, 12:04 AM