This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Resurrect add_dependencies() and target_link_libraries()
AbandonedPublic

Authored by chapuni on Feb 27 2014, 11:30 AM.

Details

Reviewers
rafael
Summary

Note, header dependencies are updated since r201842^.

Diff Detail

Event Timeline

Do you update these dependencies by hand or do you have a script or some other automation tool? If you have a script, it would be great if you committed it.

This looks good to me, but I'd like Rafael to take a look as well and see if this is the direction he was thinking too.

Dmitri, header deps were made by hand and by copying from build.ninja generated by my another patch, "tddeps".

See also http://llvm-reviews.chandlerc.com/D2879

This will always use INTERFACE. The current setup has logic for
deciding between INTERFACE, PUBLIC and PRIVATE. Wont this produce the
wrong result when doing shared builds?

What I had in mind was defining a LLVM_LINK_TYPE that is INTERFACE,
PUBLIC or PRIVATE depending on the build type. Is that possible?

I was looking at AddLLVM.cmake, but I don't quite understand it. For
example, where is ARG_MODULE set?

Cheers,
Rafael

chandlerc resigned from this revision.Mar 29 2015, 11:37 AM
chandlerc removed a reviewer: chandlerc.

This seems stalled. Update and add me back if you want me to take a look at it.

chapuni abandoned this revision.Nov 4 2016, 1:48 PM