This is an archive of the discontinued LLVM Phabricator instance.

Standardized formatting for command options exempted from clang-format
ClosedPublic

Authored by k8stone on Aug 26 2016, 11:11 AM.

Details

Reviewers
jingham
Summary

Tables of command options in LLDB benefit from hand-formatting to make it easier to scan a set of options with a relatively large number of positional arguments. This proposed patch standardizes their formatting throughout LLDB and applies surrounding directives to exempt them from being formatted.

These kinds of exemptions should be rare cases that benefit significantly from alternative formatting. They also imply a long-term obligation to maintain their format since the automated tools will not do so.

Diff Detail

Event Timeline

k8stone updated this revision to Diff 69406.Aug 26 2016, 11:11 AM
k8stone retitled this revision from to Standardized formatting for command options exempted from clang-format.
k8stone updated this object.
k8stone added a reviewer: jingham.
k8stone added a project: Restricted Project.
jingham accepted this revision.Aug 26 2016, 12:09 PM
jingham edited edge metadata.

Sweet! That looks much nicer. You might want to put a comment in the OptionDefinition class suggesting how to format these, especially if the lldb coding conventions doc is going away as it probably should. But that doesn't need to hold up this commit.

This revision is now accepted and ready to land.Aug 26 2016, 12:09 PM
k8stone updated this revision to Diff 69425.Aug 26 2016, 12:56 PM
k8stone edited edge metadata.

Spurious comma following a comment in CommandObjectTarget.cpp removed

k8stone closed this revision.Aug 26 2016, 4:37 PM

Submitted to trunk.